All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Sixt <j6t@kdbg.org>
To: Jonathan Nieder <jrnieder@gmail.com>, Junio C Hamano <gitster@pobox.com>
Cc: "Ben Walton" <bdwalton@gmail.com>,
	git@vger.kernel.org, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH] t/README: tests can use perl even with NO_PERL
Date: Mon, 28 Oct 2013 20:46:17 +0100	[thread overview]
Message-ID: <526EBF09.8070200@kdbg.org> (raw)
In-Reply-To: <20131028192216.GB4242@google.com>

Am 28.10.2013 20:22, schrieb Jonathan Nieder:
> The git build system supports a NO_PERL switch to avoid installing
> perl bindings or other features (like "git add --patch") that rely on
> perl on runtime, but even with NO_PERL it has not been possible for a
> long time to run tests without perl.  Helpers such as
> 
> 	nul_to_q () {
> 		"$PERL_PATH" -pe 'y/\000/Q/'
> 	}
> 
> use perl as a better tr or sed and are regularly used in tests without
> worrying to add a PERL prerequisite.
> 
> Perl is portable enough that it seems fine to keep relying on it for
> this kind of thing in tests (and more readable than the alternative of
> trying to find POSIXy equivalents).  Update the test documentation to
> clarify this.

Thank you for the clarification!

-- Hannes

  reply	other threads:[~2013-10-28 19:46 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-18 21:17 [PATCH] Avoid broken Solaris tr Ben Walton
2013-06-18 22:31 ` Junio C Hamano
2013-10-28  9:02   ` Ben Walton
2013-10-28  9:13     ` [PATCH] Avoid difference in tr semantics between System V and BSD Ben Walton
2013-10-28 18:07       ` Johannes Sixt
2013-10-28 18:27         ` Jonathan Nieder
2013-10-28 19:08           ` Junio C Hamano
2013-10-28 19:22             ` [PATCH] t/README: tests can use perl even with NO_PERL Jonathan Nieder
2013-10-28 19:46               ` Johannes Sixt [this message]
2013-10-28 19:54               ` Jeff King
2013-10-28 21:04                 ` Jonathan Nieder
2013-10-28 21:43                   ` Ben Walton
2013-10-29  1:18                   ` [RFC/PATCH 0/3] perl Jeff King
2013-10-29  1:19                     ` [PATCH 1/3] use @@PERL@@ in built scripts Jeff King
2013-10-29 19:41                       ` Junio C Hamano
2013-10-29  1:22                     ` [PATCH 2/3] t: provide a perl() function which uses $PERL_PATH Jeff King
2013-10-29  1:23                     ` [PATCH 3/3] t: use perl instead of "$PERL_PATH" where applicable Jeff King
2013-10-28 21:04             ` [PATCH] Avoid difference in tr semantics between System V and BSD Ben Walton
2013-10-28 21:12               ` Ben Walton
2013-10-28 21:30                 ` Junio C Hamano
2013-10-28 21:40                   ` Ben Walton
2013-10-28 21:43                     ` Ben Walton
2013-10-28 21:43                   ` Ben Walton
2013-10-30 17:39                     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=526EBF09.8070200@kdbg.org \
    --to=j6t@kdbg.org \
    --cc=avarab@gmail.com \
    --cc=bdwalton@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jrnieder@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.