From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Illegal use of FP ops in clock_ti814x.c
Date: Mon, 28 Oct 2013 17:55:52 -0400 [thread overview]
Message-ID: <526EDD68.3050907@ti.com> (raw)
In-Reply-To: <20131027211157.1AF2E380495@gemini.denx.de>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 10/27/2013 05:11 PM, Wolfgang Denk wrote:
> Dear Matt,
>
> I hope you are the right person to address this to - if not,
> please help to redirect to the current responsible developer.
>
> Function pll_sigma_delta_val() in
> arch/arm/cpu/armv7/am33xx/clock_ti814x.c incorrectly uses "float"
> data, which results in FP operations which are not permitted in
> U-Boot.
>
> The actual computation appears simple enough so a rewrite of the
> code without using any floating point operations should be fairly
> easy, but I don't understand the actual logic of this code, so I'd
> rather leave this to someone who does.
>
> Could you please help and clean up these three lines of code?
Matt's moved on to Linaro now (and this is a more public poke to
update the maintainers entry you owe me). Care to look at this?
- --
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBAgAGBQJSbt1nAAoJENk4IS6UOR1Wdy8P/RT18/UG5TBQugaSdqAkscS1
oMRz5M35qZvUuTjRj7JwRMXs/WGhVLO4NP5zDM0eYdo6pD/Z4ZnCPXUpRa46w4X/
xvusu9m+fpKsy/+gEOeOw4+JQ1OnMCLuP0OxpJfvKYwXEOjji5mGxAhxpCTogBFX
6l6vAYiEcYYG2S58AuGFYL9l0y0x7kZNnvfAzM5xJgxNOhxmGefGABuILXWRs5mt
rHQBrPlofc+E2n73BxSAxk35cqy1Fm6CP35ETuKb3NMonoYbtXebh3ADyjxaNdf6
IZHpTserTNLaSGUSq2QVrF9zOnQKj/R4fuTbV7biUI3lF5JqVLO+jsx+E5XwTJpD
bkQlD+vbmSnzK5HebUG6qEFHWxChjPJ0URSvlb0WBrlQJX9TkK4Xetq9ou6FaSpR
xnZ/X6zDuBiuyWdmw01D0en8WSTMHCnYHQ7yAZjL3tuvjoJ6p4xCMFe2FZJE4UUn
p1pT+h3zMipwjDrZ57NureCY7mWdCsRBgIR18MTmjF7XYzo7+4F+yi2aaGifGmPu
zo1zp+1ijjQCVylw2OXGp09ej6azJcVoaRVS7FBEtd5u6MaSBhgfXTvR1bSB5mqw
PbxlnXgfumv+VK3S036FtFXuT8lCx6kWlSLOa9HZSHrwjO0eQv+IeuoVigUnzfq/
oMHEAwDoaJbMjPDgFE2O
=c8xm
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2013-10-28 21:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-27 21:11 [U-Boot] Illegal use of FP ops in clock_ti814x.c Wolfgang Denk
2013-10-28 21:55 ` Tom Rini [this message]
2013-10-28 23:19 ` Måns Rullgård
2013-10-28 23:56 ` Wolfgang Denk
2013-10-29 0:54 ` Måns Rullgård
2013-10-29 10:48 ` Wolfgang Denk
2013-10-29 12:23 ` Tom Rini
2014-01-28 17:48 ` Matt Porter
2013-10-29 12:44 ` Måns Rullgård
2014-02-21 19:14 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=526EDD68.3050907@ti.com \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.