From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Alexander Duyck <alexander.duyck@gmail.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, alexander.h.duyck@intel.com
Subject: Re: [PATCH 0/2] net_sched: Remove broken tc actions
Date: Mon, 28 Oct 2013 18:57:29 -0400 [thread overview]
Message-ID: <526EEBD9.8040006@mojatatu.com> (raw)
In-Reply-To: <526D799C.9050905@gmail.com>
On 10/27/13 16:37, Alexander Duyck wrote:
> The primary use case for act_skbedit was to have it associated with a
> filter. I based it off of act_simple so it isn't surprising that it
> inherited this issue.
Thats almost 100% of the use cases.
>
> From what I can tell all of the other actions are just using
> tcf_hash_search for lookup. Is there anything special that is needed in
> order to add the lookup call, or could we just add a one liner
> associating simple and skbedit lookup with tcf_hash_search?
>
Yes, that would do it. But dont bother - let me just send a generic
patch that will assume that for any other action that doesnt do it.
Will do it likely tomorow.
cheers,
jamal
prev parent reply other threads:[~2013-10-28 22:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-27 13:40 [PATCH 0/2] net_sched: Remove broken tc actions Eric W. Biederman
2013-10-27 13:42 ` [PATCH 1/2] net_sched: Remove broken act_skbedit Eric W. Biederman
2013-10-27 13:43 ` [PATCH 2/2] net_sched: Remove broken act_simple Eric W. Biederman
2013-10-27 16:58 ` [PATCH 0/2] net_sched: Remove broken tc actions Jamal Hadi Salim
2013-10-27 20:37 ` Alexander Duyck
2013-10-28 22:57 ` Jamal Hadi Salim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=526EEBD9.8040006@mojatatu.com \
--to=jhs@mojatatu.com \
--cc=alexander.duyck@gmail.com \
--cc=alexander.h.duyck@intel.com \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.