From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bo Shen <voice.shen@atmel.com>
Date: Tue, 29 Oct 2013 13:24:19 +0800
Subject: [U-Boot] [PATCH] arm: at91: support for the Calao USB-A9263
 board (based on AT91SAM9263)
In-Reply-To: <526ED792.6070203@gmail.com>
References: <1382902453-6659-1-git-send-email-mateusz.kulikowski@gmail.com>
	<526DEEAB.4090403@atmel.com> <526ED792.6070203@gmail.com>
Message-ID: <526F4683.4030205@atmel.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Mateusz Kulikowski,

On 10/29/2013 05:30, Mateusz Kulikowski wrote:
> Hi Bo Shen,
>
> Thanks for the check, please see below.
>
> On 28.10.2013 05:57, Bo Shen wrote:
>> Hi Mateusz Kulikowski,
>>    Add Andreas in loop.
>>
>> On 10/28/2013 03:34, Mateusz Kulikowski wrote:
> (...)
>>> +    /*
>>> +     * Disable pull-up on:
>>> +     *  RXDV (PC25) => PHY normal mode (not Test mode)
>>> +     *  ERX0 (PE25) => PHY ADDR0
>>> +     *  ERX1 (PE26) => PHY ADDR1 => PHYADDR = 0x0
>>> +     *
>>> +     * PHY has internal pull-down
>>> +     */
>>> +    writel(1 << 25, &pio->pioc.pudr);
>>> +    writel((1 << 25) | (1 << 26), &pio->pioe.pudr);
>>
>> Use GPIO API instead of hard code.
>
> Should I also update (in separate patch) at91sam9263ek board
> (code is the same there, bad side is - I don't have that board to test)?

You can use GPIO API for USB-A9263 in this patch. And send another patch 
to fix at91sam9263ek board (I can help test the patch for at91sam9263ek 
board).

>>> +
>>> +#define CONFIG_SYS_TEXT_BASE 0x23f00000
>>
>> This address should be considered as u-boot is top down map, so if
>> your system only 64MiB, there is only 1MiB left.
>
> I don't understand something here:
> - this address is hardcoded in AT91bootstrap (as well as image size -
> 0x31000),

Yes, that's true. And this is a pain for us :(
Here just a reminder for the text base.

> - I can change it, but it will not boot on "stock" board - should we force
> people to recompile AT91bootstrap if they want to use new U-Boot?

(If you plan to modify the text base, you must ask for that.)
For new version bootstrap, we have change this address to 0x21f00000 for 
boards only have 64MiB SDRAM.

> or
> - Should I add low-level initialization to boot U-Boot from Dataflash
> without AT91bootstrap (this is a bit more work)?

I am working for SPL for Atmel EK boards, now focus on sama5d3xek board. 
After finished, I will submit then patch and go on working for other board.

> or
> - There is another way I'm not aware of (perhaps relocate U-Boot in RAM)?
>
> Best Regards,
> Mateusz Kulikowski

Best Regards,
Bo Shen