From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen Gang Subject: Re: [PATCH] arch: use ASM_NL instead of ';' for assembler new line character in the macro Date: Tue, 29 Oct 2013 15:57:03 +0800 Message-ID: <526F6A4F.9040507@asianux.com> References: <526E3CE2.2070405@asianux.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Max Filippov Cc: "vgupta@synopsys.com" , James Hogan , Al Viro , Arnd Bergmann , "linux-kernel@vger.kernel.org" , Linux-Arch List-Id: linux-arch.vger.kernel.org On 10/28/2013 07:18 PM, Max Filippov wrote: > Hi Chen, > > On Mon, Oct 28, 2013 at 2:30 PM, Chen Gang wrote: >> > For some toolchains, they use another character as newline in a macro >> > (e.g. arc uses '`'), so for generic assembly code, need use ASM_NL (a >> > macro) instead of ';' for it. >> > Since "linux/export.h" are mainly used for exporting work, then our fix >> > more likely belongs to "linux/linkage.h", and we need add the related >> > checking in "linkage.h". >> > >> > Also need notice 80 columns wrap, and '\t' for each line. >> > >> > >> > Signed-off-by: Chen Gang >> > --- >> > arch/arc/include/asm/linkage.h | 2 + >> > include/asm-generic/vmlinux.lds.h | 350 +++++++++++++++++++------------------ > Actually vmlinux.lds.h is not an assembly code, but rather a linker script, > later preprocessed by cpp. > Consult: do xtensa also has its own ASM_NL? :-) Thanks. -- Chen Gang