From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Subject: Re: [PATCH 2/3] ASoC: fsl_ssi: Add dual fifo mode support Date: Tue, 29 Oct 2013 07:42:41 -0500 Message-ID: <526FAD41.2000805@tabi.org> References: <02f8867363ed3038a0a70703856e4b642fef4339.1383047327.git.b42378@freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <02f8867363ed3038a0a70703856e4b642fef4339.1383047327.git.b42378@freescale.com> Sender: linux-doc-owner@vger.kernel.org To: Nicolin Chen , shawn.guo@linaro.org, broonie@kernel.org Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, alsa-devel@alsa-project.org, rob.herring@calxeda.com, mark.rutland@arm.com, swarren@wwwdotorg.org, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, s.hauer@pengutronix.de, b32955@freescale.com List-Id: alsa-devel@alsa-project.org Nicolin Chen wrote: > By enabling dual fifo mode, it would allow SSI enter a better performance > to transimit/receive data without occasional hardware underrun/overrun. Have you measured any real performance gain with this patch? I considered adding dual-FIFO support when I originally wrote this driver, but it didn't appear to have any real benefit, but it used twice as many DMA channels. I'm concerned that this is another patch that just enables a useless feature. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from muin.pair.com (muin.pair.com [209.68.1.55]) by ozlabs.org (Postfix) with ESMTP id 0DD902C0351 for ; Tue, 29 Oct 2013 23:42:44 +1100 (EST) Message-ID: <526FAD41.2000805@tabi.org> Date: Tue, 29 Oct 2013 07:42:41 -0500 From: Timur Tabi MIME-Version: 1.0 To: Nicolin Chen , shawn.guo@linaro.org, broonie@kernel.org Subject: Re: [PATCH 2/3] ASoC: fsl_ssi: Add dual fifo mode support References: <02f8867363ed3038a0a70703856e4b642fef4339.1383047327.git.b42378@freescale.com> In-Reply-To: <02f8867363ed3038a0a70703856e4b642fef4339.1383047327.git.b42378@freescale.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, pawel.moll@arm.com, linux-doc@vger.kernel.org, s.hauer@pengutronix.de, swarren@wwwdotorg.org, linux-kernel@vger.kernel.org, rob.herring@calxeda.com, b32955@freescale.com, dmaengine@vger.kernel.org, ijc+devicetree@hellion.org.uk, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Nicolin Chen wrote: > By enabling dual fifo mode, it would allow SSI enter a better performance > to transimit/receive data without occasional hardware underrun/overrun. Have you measured any real performance gain with this patch? I considered adding dual-FIFO support when I originally wrote this driver, but it didn't appear to have any real benefit, but it used twice as many DMA channels. I'm concerned that this is another patch that just enables a useless feature. From mboxrd@z Thu Jan 1 00:00:00 1970 From: timur@tabi.org (Timur Tabi) Date: Tue, 29 Oct 2013 07:42:41 -0500 Subject: [PATCH 2/3] ASoC: fsl_ssi: Add dual fifo mode support In-Reply-To: <02f8867363ed3038a0a70703856e4b642fef4339.1383047327.git.b42378@freescale.com> References: <02f8867363ed3038a0a70703856e4b642fef4339.1383047327.git.b42378@freescale.com> Message-ID: <526FAD41.2000805@tabi.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Nicolin Chen wrote: > By enabling dual fifo mode, it would allow SSI enter a better performance > to transimit/receive data without occasional hardware underrun/overrun. Have you measured any real performance gain with this patch? I considered adding dual-FIFO support when I originally wrote this driver, but it didn't appear to have any real benefit, but it used twice as many DMA channels. I'm concerned that this is another patch that just enables a useless feature.