All of lore.kernel.org
 help / color / mirror / Atom feed
From: Przemyslaw Marczak <p.marczak@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] mmc: sdhci: Avoid commands errors by simple timeout adaptation.
Date: Tue, 29 Oct 2013 14:02:05 +0100	[thread overview]
Message-ID: <526FB1CD.6030003@samsung.com> (raw)
In-Reply-To: <525DA307.7060305@samsung.com>

Dear Pantelis,
You don't reply for a long time. Could you look on it at this time?

On 10/15/2013 10:18 PM, Przemyslaw Marczak wrote:
> Hello Pantelis,
>
> Could you look at this patch, please?
>
> On 10/08/2013 06:12 PM, Przemyslaw Marczak wrote:
>> Old command timeout value was too small and it caused I/O errors which
>> led to uncompleted read/write/erase operations and filesystem errors.
>> Timeout adaptation fixes this issue.
>>
>> Changes in sdhci_send_command() function:
>> - change timeout variable to static
>> - increase default command timeout to 100 ms
>> - add definition of max command timeout value,
>>    which can be redefined in each board config file
>> - wait for card ready state for max defined time
>>    if it doesn't exceed defined maximum or return COMM_ERR
>>
>> Once successfully increased timeout value will be used in next function
>> call. This fix was tested on Goni, Trats, Trats2 boards by testing UMS
>> on MMC storage.
>>
>> Changes v2:
>> - move global variable cmd_timeout into function sdhci_send_command()
>> - change condition "==" to ">=" when comparing time with timeout
>> - print information about timeout increasing and card busy timeout
>>
>> Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com>
>> Cc: Pantelis Antoniou <panto@antoniou-consulting.com>
>
> Thank you.
>
>

Regards
-- 
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com

  reply	other threads:[~2013-10-29 13:02 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-01 12:16 [U-Boot] [PATCH] mmc: sdhci: Avoid commands errors by simple timeout adaptation Przemyslaw Marczak
2013-10-01 15:50 ` Pantelis Antoniou
2013-10-01 16:59   ` Przemyslaw Marczak
2013-10-02  9:40     ` Pantelis Antoniou
2013-10-04  4:39 ` Jaehoon Chung
2013-10-04 13:17   ` Przemyslaw Marczak
2013-10-08 16:12 ` [U-Boot] [PATCH v2] " Przemyslaw Marczak
2013-10-15 20:18   ` Przemyslaw Marczak
2013-10-29 13:02     ` Przemyslaw Marczak [this message]
2013-10-29 13:08       ` Pantelis Antoniou
2013-10-29 13:24         ` Przemyslaw Marczak
2013-10-29 13:28           ` Pantelis Antoniou
2013-10-29 13:39             ` Mateusz Zalega
2013-10-31  7:49 ` [U-Boot] [PATCH] " Pantelis Antoniou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=526FB1CD.6030003@samsung.com \
    --to=p.marczak@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.