All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Cohen <david.a.cohen@linux.intel.com>
To: balbi@ti.com
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC/PATCH 2/2] usb: ffs/dwc3: pad epout buffer size when not aligned to maxpacketsize
Date: Tue, 29 Oct 2013 07:24:26 -0700	[thread overview]
Message-ID: <526FC51A.2080008@linux.intel.com> (raw)
In-Reply-To: <20131029133724.GH2776@gimli>

>> +		/*
>> +		 * DWC3 requires buffer size to be aligned to maxpacketsize
>> +		 * of an out endpoint.
>> +		 * FIXME: a more generic solution might be necessary.
>> +		 */
> 
> see, gadget drivers shouldn't have to know about DWC3 at all. They need
> to know that current UDC has a quirk where EP OUT transactions need to
> be aligned to wMaxPacketSize, so what I was expecting to see here was:
> 
> 		if (test_bit(USB_GADGET_QUIRK_EP_OUT_ALIGNED_SIZE, &gadget->qirks) &&
> 			!IS_ALIGNED(len, ep->ep->desc->wMaxPacketSize))
> 			len = align_length(orig_len, wMaxPacketSize);

That makes sense. I'll send a new version.

Thanks,

David Cohen


      reply	other threads:[~2013-10-29 14:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-29  1:12 [RFC/PATCH 0/2] patchset to workaround f_fs for DWC3 David Cohen
2013-10-29  1:12 ` [RFC/PATCH 1/2] usb: gadget: re-introduce gadget_is_dwc3() David Cohen
2013-10-29 13:34   ` Felipe Balbi
2013-10-29  1:13 ` [RFC/PATCH 2/2] usb: ffs/dwc3: pad epout buffer size when not aligned to maxpacketsize David Cohen
2013-10-29 13:37   ` Felipe Balbi
2013-10-29 14:24     ` David Cohen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=526FC51A.2080008@linux.intel.com \
    --to=david.a.cohen@linux.intel.com \
    --cc=balbi@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.