From mboxrd@z Thu Jan 1 00:00:00 1970 From: Levente Kurusa Subject: [PATCH trivial] ata: libata-eh: Remove unnecessary snprintf arithmetic Date: Tue, 29 Oct 2013 19:38:38 +0100 Message-ID: <527000AE.8060506@linux.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f46.google.com ([74.125.83.46]:44288 "EHLO mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751333Ab3J2Sik (ORCPT ); Tue, 29 Oct 2013 14:38:40 -0400 Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Tejun Heo , Linux IDE/ATA Dev , LKML Remove an unnecessary arithmetic operation from a call to snprintf, because the size parameter of snprintf includes the trailing null byte. Signed-off-by: Levente Kurusa --- diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c index f9476fb..b7c4146 100644 --- a/drivers/ata/libata-eh.c +++ b/drivers/ata/libata-eh.c @@ -2427,7 +2434,7 @@ static void ata_eh_link_report(struct ata_link *link) memset(tries_buf, 0, sizeof(tries_buf)); if (ap->eh_tries < ATA_EH_MAX_TRIES) - snprintf(tries_buf, sizeof(tries_buf) - 1, " t%d", + snprintf(tries_buf, sizeof(tries_buf), " t%d", ap->eh_tries); if (ehc->i.dev) {