From mboxrd@z Thu Jan 1 00:00:00 1970 From: Levente Kurusa Subject: Re: [PATCH trivial] ata: libata-eh: Remove unnecessary snprintf arithmetic Date: Tue, 29 Oct 2013 19:58:55 +0100 Message-ID: <5270056F.4030702@linux.com> References: <527000AE.8060506@linux.com> <20131029185302.GA22261@mtj.dyndns.org> Reply-To: levex@linux.com Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-ea0-f178.google.com ([209.85.215.178]:56109 "EHLO mail-ea0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752736Ab3J2S65 (ORCPT ); Tue, 29 Oct 2013 14:58:57 -0400 In-Reply-To: <20131029185302.GA22261@mtj.dyndns.org> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Tejun Heo Cc: Linux IDE/ATA Dev , LKML 2013-10-29 19:53 keltez=E9ssel, Tejun Heo =EDrta: > Hello, >=20 > On Tue, Oct 29, 2013 at 07:38:38PM +0100, Levente Kurusa wrote: >> Remove an unnecessary arithmetic operation from a call to snprintf, = because >> the size parameter of snprintf includes the trailing null byte. >> >> Signed-off-by: Levente Kurusa >> --- >> diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c >> index f9476fb..b7c4146 100644 >> --- a/drivers/ata/libata-eh.c >> +++ b/drivers/ata/libata-eh.c >> @@ -2427,7 +2434,7 @@ static void ata_eh_link_report(struct ata_link= *link) >> >> memset(tries_buf, 0, sizeof(tries_buf)); >=20 > While at it, can you please remove the above and just initialize the > buffer to "" on definition? Sure, sending v2 in a moment. --=20 Regards, Levente Kurusa