From: Chen Gang <gang.chen@asianux.com>
To: Joern Rennecke <joern.rennecke@embecosm.com>,
James Hogan <james.hogan@imgtec.com>,
Rusty Russell <rusty@rustcorp.com.au>,
Takashi Iwai <tiwai@suse.de>,
"dhowells@redhat.com" <dhowells@redhat.com>
Cc: Vineet Gupta <Vineet.Gupta1@synopsys.com>,
"jeremy.bennett@embecosm.com" <jeremy.bennett@embecosm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Claudiu Zissulescu <Claudiu.Zissulescu@synopsys.com>,
Francois Bedard <Francois.Bedard@synopsys.com>,
Max Filippov <jcmvbkbc@gmail.com>,
Al Viro <viro@zeniv.linux.org.uk>, Arnd Bergmann <arnd@arndb.de>
Subject: [PATCH-next v3] kernel/system_certificate.S: use real contents instead of macro GLOBAL()
Date: Wed, 30 Oct 2013 09:11:28 +0800 [thread overview]
Message-ID: <52705CC0.8020909@asianux.com> (raw)
In-Reply-To: <526F1ACE.7080409@asianux.com>
If a macro is only used within 2 times, and also its contents are
within 2 lines, recommend to expand it to shrink code line.
For our case, the macro is not portable either: some architectures'
assembler may use another character to mark newline in a macro (e.g.
'`' for arc), which will cause issue.
If still want to use macro and let it portable enough, it will also
need include additional header file (e.g "#include <linux/linkage.h>",
although it also need be fixed).
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
kernel/system_certificates.S | 10 ++++------
1 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/kernel/system_certificates.S b/kernel/system_certificates.S
index 552d47b..4aef390 100644
--- a/kernel/system_certificates.S
+++ b/kernel/system_certificates.S
@@ -1,12 +1,10 @@
#include <linux/export.h>
#include <linux/init.h>
-#define GLOBAL(name) \
- .globl VMLINUX_SYMBOL(name); \
- VMLINUX_SYMBOL(name):
-
__INITRODATA
-GLOBAL(system_certificate_list)
+ .globl VMLINUX_SYMBOL(system_certificate_list)
+VMLINUX_SYMBOL(system_certificate_list):
.incbin "kernel/x509_certificate_list"
-GLOBAL(system_certificate_list_end)
+ .globl VMLINUX_SYMBOL(system_certificate_list_end)
+VMLINUX_SYMBOL(system_certificate_list_end):
--
1.7.7.6
next prev parent reply other threads:[~2013-10-30 1:12 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-23 6:04 [Suggestion] arc: compiler: bug: about an arc compiler's bug which is not in gcc main source code Chen Gang
2013-09-23 6:12 ` Chen Gang
2013-09-23 6:39 ` Vineet Gupta
2013-09-23 6:53 ` Chen Gang
2013-10-23 2:00 ` Chen Gang
2013-10-23 2:48 ` Joern Rennecke
2013-10-23 3:10 ` Chen Gang
2013-10-23 11:14 ` Chen Gang
2013-10-24 5:31 ` [PATCH] kernel/modsign_certificate.S: use real contents instead of macro GLOBAL() Chen Gang
2013-10-24 6:03 ` Richard Weinberger
2013-10-24 6:26 ` Chen Gang
2013-10-24 6:44 ` Richard Weinberger
2013-10-24 7:40 ` Chen Gang
2013-10-24 17:28 ` Portable assmbler code - newline (was Re: [PATCH] kernel/modsign_certificate.S: use real contents instead of macro GLOBAL()) Vineet Gupta
2013-10-24 19:41 ` Geert Uytterhoeven
2013-10-25 5:10 ` Vineet Gupta
2013-10-26 13:38 ` Chen Gang
2013-10-27 7:28 ` Portable assmbler code - newline Vineet Gupta
2013-10-27 12:34 ` Chen Gang
2013-10-27 13:57 ` Chen Gang
2013-10-24 15:29 ` [PATCH] kernel/modsign_certificate.S: use real contents instead of macro GLOBAL() Josh Boyer
2013-10-26 2:42 ` Chen Gang
2013-10-26 14:40 ` Chen Gang F T
2013-10-29 2:17 ` [PATCH v2] " Chen Gang
2013-10-30 1:11 ` Chen Gang [this message]
2013-10-30 12:57 ` [PATCH-next v3] kernel/system_certificate.S: " David Howells
2013-10-31 0:47 ` Chen Gang
2013-10-23 2:51 ` [Suggestion] arc: compiler: bug: about an arc compiler's bug which is not in gcc main source code Francois Bedard
2013-10-23 3:12 ` Chen Gang
2013-10-30 1:43 ` Chen Gang
2013-10-30 12:10 ` Chen Gang
2013-10-31 7:48 ` Vineet Gupta
2013-10-31 8:50 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52705CC0.8020909@asianux.com \
--to=gang.chen@asianux.com \
--cc=Claudiu.Zissulescu@synopsys.com \
--cc=Francois.Bedard@synopsys.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=arnd@arndb.de \
--cc=dhowells@redhat.com \
--cc=james.hogan@imgtec.com \
--cc=jcmvbkbc@gmail.com \
--cc=jeremy.bennett@embecosm.com \
--cc=joern.rennecke@embecosm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=tiwai@suse.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.