All of lore.kernel.org
 help / color / mirror / Atom feed
From: jiada_wang@mentor.com (jiada)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: imx: replace imx6q_restart() with mxc_restart()
Date: Tue, 29 Oct 2013 20:13:02 -0700	[thread overview]
Message-ID: <5270793E.9000605@mentor.com> (raw)
In-Reply-To: <20131028074524.GE2839@S2101-09.ap.freescale.net>

Hi

On 10/28/2013 12:45 AM, Shawn Guo wrote:
> On Sun, Oct 27, 2013 at 07:41:23PM -0700, jiada wrote:
>> as per discussion locally, when do you think you will post the fix patch
>> for the system hang I observed?
>> I would like to test for your patch, and then pull it to my kernel.
>
> Sorry, Jiada.  After another closer look at the fix I provided before,
> it's not correct, because emergency_restart() is a function that is safe
> to call in interrupt context, while migrate_to_reboot_cpu() is not.
> That said, we cannot call migrate_to_reboot_cpu() in emergency_restart()
> at all.
>
> I just found a more easier fix at platform level.  The following is what
> you need to do on your 3.5 kernel.
>
> 1. Apply the following change
>
> https://git.linaro.org/gitweb?p=people/shawnguo/linux-2.6.git;a=commitdiff;h=6050d181a4fd4abb745506a6e565d55f1f9df964
>
> 2. Remove imx_src_prepare_restart() from imx6q_restart().
>
> I will send a patch against the latest kernel.
>
Thanks Shawn, I have verified with these two changes,
system reboot by "echo b > /proc/sysrq-trigger" works
for me.

> Shawn
>

Thanks,
Jiada

  reply	other threads:[~2013-10-30  3:13 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-06  9:06 [PATCH] ARM: imx: replace imx6q_restart() with mxc_restart() Shawn Guo
2013-10-08 15:32 ` Nathan Lynch
2013-10-08 15:49   ` Shawn Guo
     [not found] ` <857E9EDCA6C0904DB3357321AA9123EB62506837@NA-MBX-01.mgc.mentorg.com>
2013-10-21  3:32   ` jiada
2013-10-21  4:59     ` Shawn Guo
     [not found]       ` <857E9EDCA6C0904DB3357321AA9123EB62506BEA@NA-MBX-01.mgc.mentorg.com>
2013-10-21  6:13         ` jiada
2013-10-21  7:04           ` Shawn Guo
2013-10-28  2:41             ` jiada
2013-10-28  2:52               ` Shawn Guo
2013-10-28  7:45               ` Shawn Guo
2013-10-30  3:13                 ` jiada [this message]
2013-10-30 17:54                   ` Russell King - ARM Linux
2013-10-31  5:23                     ` Shawn Guo
2013-10-31  5:31                     ` jiada
2013-10-28  5:17 ` Olof Johansson
2013-10-28  8:14   ` Shawn Guo
2013-10-28 17:46     ` Olof Johansson
2013-10-29  2:06       ` Shawn Guo
2013-10-29  8:53         ` Lothar Waßmann
2013-10-29 11:37           ` Russell King - ARM Linux
2013-10-29 13:37             ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5270793E.9000605@mentor.com \
    --to=jiada_wang@mentor.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.