Re: [PATCH] drm/ttm: Handle in memory region copies

From: Thomas Hellstrom <thellstrom@vmware.com>
To: Jakob Bornecrantz <jakob@vmware.com>
Cc: Dave Airlie <airlied@redhat.com>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/ttm: Handle in memory region copies
Date: Wed, 30 Oct 2013 08:52:20 +0100	[thread overview]
Message-ID: <5270BAB4.1010806@vmware.com> (raw)
In-Reply-To: <1382102289-23664-1-git-send-email-jakob@vmware.com>

On 10/18/2013 03:18 PM, Jakob Bornecrantz wrote:
> Reviewed-by: Thomas Hellström <thellstrom@vmware.com>
> Signed-off-by: Jakob Bornecrantz <jakob@vmware.com>
> Cc: Dave Airlie <airlied@redhat.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: stable@vger.kernel.org
> ---
>   drivers/gpu/drm/ttm/ttm_bo_util.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_bo_util.c b/drivers/gpu/drm/ttm/ttm_bo_util.c
> index 8be35c8..037f101 100644
> --- a/drivers/gpu/drm/ttm/ttm_bo_util.c
> +++ b/drivers/gpu/drm/ttm/ttm_bo_util.c
> @@ -342,7 +342,9 @@ int ttm_bo_move_memcpy(struct ttm_buffer_object *bo,
>   	if (old_iomap == NULL && ttm == NULL)
>   		goto out2;
>   
> -	if (ttm->state == tt_unpopulated) {
> +	/* TTM might be null for moves within the same region.
> +	 */
> +	if (ttm && ttm->state == tt_unpopulated) {
>   		ret = ttm->bdev->driver->ttm_tt_populate(ttm);
>   		if (ret) {
>   			/* if we fail here don't nuke the mm node

LGTM. There are a couple of other fixes needed in this function as well.

/Thomas
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel