From: Olivier MATZ <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Thomas Monjalon
<thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH] config: fix combined/shared lib
Date: Wed, 30 Oct 2013 09:53:04 +0100 [thread overview]
Message-ID: <5270C8F0.1080306@6wind.com> (raw)
In-Reply-To: <1382522765-27254-1-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Hi Thomas,
> - Configuration for combined and shared library was only in
> the template defconfig_x86_64-default-linuxapp-gcc.
> - CONFIG_RTE_LIBNAME was in the wrong section
> - CONFIG_RTE_LIBNAME quotes were not properly removed in "make context"
> - RTE_LIBNAME had no quote in "C context" (include/rte_config.h)
acked
Just one remark about the commit log: if I understand well, the
issue related to the quote not properly removed in "make context"
is triggered by the quotes you added in the defconfig. I would reword
the commit log a bit to highlight it.
Regards,
Olivier
next prev parent reply other threads:[~2013-10-30 8:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-23 10:06 [PATCH] config: fix combined/shared lib Thomas Monjalon
[not found] ` <1382522765-27254-1-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2013-10-30 8:53 ` Olivier MATZ [this message]
[not found] ` <5270C8F0.1080306-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2013-10-30 14:57 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5270C8F0.1080306@6wind.com \
--to=olivier.matz-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.