All of lore.kernel.org
 help / color / mirror / Atom feed
From: Huang Shijie <b32955@freescale.com>
To: Sourav Poddar <sourav.poddar@ti.com>
Cc: marex@denx.de, computersforpeace@gmail.com,
	linux-mtd@lists.infradead.org, balbi@ti.com, dedekind1@gmail.com
Subject: Re: [Rebase/PATCHv2] drivers: mtd: m25p80: Add quad read support.
Date: Wed, 30 Oct 2013 17:29:16 +0800	[thread overview]
Message-ID: <5270D16C.6030802@freescale.com> (raw)
In-Reply-To: <1383124802-25079-1-git-send-email-sourav.poddar@ti.com>

于 2013年10月30日 17:20, Sourav Poddar 写道:
> @@ -1077,6 +1221,12 @@ static int m25p_probe(struct spi_device *spi)
>   		flash->addr_width = 4;
>   		if (JEDEC_MFR(info->jedec_id) == CFI_MFR_AMD) {
>   			/* Dedicated 4-byte command set */
> +			if (flash->quad_read)
> +				flash->read_opcode = OPCODE_QUAD_READ_4B;
> +			else
> +				flash->read_opcode = flash->fast_read ?
> +					OPCODE_FAST_READ_4B :
> +					OPCODE_NORM_READ_4B;
>   			flash->read_opcode = flash->fast_read ?
>   				OPCODE_FAST_READ_4B :
>   				OPCODE_NORM_READ_4B;
you missed to remove these three lines above?

thanks
Huang Shijie

  reply	other threads:[~2013-10-30  9:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-30  9:20 [Rebase/PATCHv2] drivers: mtd: m25p80: Add quad read support Sourav Poddar
2013-10-30  9:29 ` Huang Shijie [this message]
2013-10-30  9:32   ` Sourav Poddar
2013-10-30 10:18 ` Huang Shijie
2013-10-30 10:19   ` Sourav Poddar
2013-10-30 10:25     ` Huang Shijie
2013-10-30 13:38       ` Marek Vasut
2013-10-30 23:19 ` Brian Norris
2013-10-31  5:01   ` Sourav Poddar
2013-10-31 16:05     ` Brian Norris
2013-11-02  5:48       ` Sourav Poddar
2013-11-05  3:49         ` Brian Norris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5270D16C.6030802@freescale.com \
    --to=b32955@freescale.com \
    --cc=balbi@ti.com \
    --cc=computersforpeace@gmail.com \
    --cc=dedekind1@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marex@denx.de \
    --cc=sourav.poddar@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.