All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC PATCH 1/7] arm: atmel: sama5d3: early enable PIO peripherals
Date: Wed, 30 Oct 2013 11:12:38 +0100	[thread overview]
Message-ID: <5270DB96.70100@denx.de> (raw)
In-Reply-To: <1383124508-8413-2-git-send-email-voice.shen@atmel.com>

Hello bo,

Am 30.10.2013 10:15, schrieb Bo Shen:
> Enable the PIO peripherals early that other peripherals.
>
> Signed-off-by: Bo Shen<voice.shen@atmel.com>
> ---
>   board/atmel/sama5d3xek/sama5d3xek.c |    3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/board/atmel/sama5d3xek/sama5d3xek.c b/board/atmel/sama5d3xek/sama5d3xek.c
> index b0965ef..7fa3ae7 100644
> --- a/board/atmel/sama5d3xek/sama5d3xek.c
> +++ b/board/atmel/sama5d3xek/sama5d3xek.c
> @@ -158,6 +158,9 @@ void lcd_show_board_info(void)
>
>   int board_early_init_f(void)
>   {
> +	at91_periph_clk_enable(ATMEL_ID_PIOA | ATMEL_ID_PIOB | ATMEL_ID_PIOC |
> +			       ATMEL_ID_PIOD | ATMEL_ID_PIOE);
> +
>   	at91_seriald_hw_init();
>
>   	return 0;

Hmm.. you do this board specific. I think, we should make there a more
generic approach.

Could we create here a

arch/arm/cpu/arm926ejs/at91/spl.c

and collect such common code?

This comment aplly also for your patch:
http://patchwork.ozlabs.org/patch/287165/

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  reply	other threads:[~2013-10-30 10:12 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-30  9:15 [U-Boot] [RFC PATCH 0/7] arm: atmel: sama5d3: enable spl boot from SD card Bo Shen
2013-10-30  9:15 ` [U-Boot] [RFC PATCH 1/7] arm: atmel: sama5d3: early enable PIO peripherals Bo Shen
2013-10-30 10:12   ` Heiko Schocher [this message]
2013-10-30 11:11   ` Andreas Bießmann
2013-10-31  2:02     ` Bo Shen
2013-10-30  9:15 ` [U-Boot] [RFC PATCH 2/7] arm: atmel: sama5d3: correct the ID for DBGU and PIT Bo Shen
2013-10-30 11:12   ` Andreas Bießmann
2013-10-31  1:32     ` Bo Shen
2013-10-30  9:15 ` [U-Boot] [RFC PATCH 3/7] arm: atmel: the offset of MULA is 18 in sama5d3 Bo Shen
2013-10-30  9:15 ` [U-Boot] [RFC PATCH 4/7] arm: atmel: sama5: correct the error define of DIV Bo Shen
2013-10-30  9:15 ` [U-Boot] [RFC PATCH 5/7] arm: atmel: add plla and mck initialize function Bo Shen
2013-10-30 11:21   ` Andreas Bießmann
2013-10-31  1:38     ` Bo Shen
2013-10-30  9:15 ` [U-Boot] [RFC PATCH 6/7] arm: atmel: add ddr2 initialization function Bo Shen
2013-10-30  9:15 ` [U-Boot] [RFC PATCH 7/7] spl: mmc: FAT support boot u-boot Bo Shen
2013-10-30 10:15   ` Heiko Schocher
2013-10-30 10:43     ` Andreas Bießmann
2013-10-30 10:57       ` Heiko Schocher
2013-10-30 11:02         ` Andreas Bießmann
2013-10-31  1:30           ` Bo Shen
2013-10-31  7:42   ` Heiko Schocher
2013-10-31  7:50     ` Bo Shen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5270DB96.70100@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.