From: Antti Palosaari <crope@iki.fi>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-media@vger.kernel.org, Jean Delvare <khali@linux-fr.org>
Subject: Re: [PATCH] rtl2830: add parent for I2C adapter
Date: Wed, 30 Oct 2013 17:51:16 +0200 [thread overview]
Message-ID: <52712AF4.5020503@iki.fi> (raw)
In-Reply-To: <20131030154553.GC3663@katana>
On 30.10.2013 17:45, Wolfram Sang wrote:
>
>>>> commit 3923172b3d700486c1ca24df9c4c5405a83e2309
>>>> i2c: reduce parent checking to a NOOP in non-I2C_MUX case
>>>
>>> Did you try reverting it? I am not sure this is the one.
>>
>> Nope, not to mentio bisect. I have done bisect few times and I am
>> not going to waste whole day of compiling and booting new kernels.
>
> Well, I intentionally asked for revert not bisect. Removing the #ifdef
> can easily be done by hand if needed and will just need one recompile to
> make sure.
Yes, but compiling whole Kernel is always pain. I dont certainly want to
do that just for testing some patches.
>> Crash disappeared whit that little patch.
>
> Yes, still I'd like to understand where the BUG came from. There are
> probably other driver in need of a fix, too.
>
>> Anyway, I am going to ask Mauro to merge that I2C parent patch and
>> maybe try to sent it stable too as it is likely a bit too late for
>> 3.12 RC.
>
> If it fixes a crash, I wouldn't consider it too late. Yet only given we
> have understood this is a proper fix.
>
> Was there a change in using CONFIG_I2C_COMPAT? Is it currently used?
Jean jsut pointed out on IRC that this patch likely fixes the issue:
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=47b6e477ed4ecacddd1f82d04d686026e08dc3db
As that patch is already applied to 3.12 it should be fine. I was
running media master which is based 3.12-rc2.
So I am sending that patch to Kernel 3.13.
regards
Antti
--
http://palosaari.fi/
next prev parent reply other threads:[~2013-10-30 15:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-21 20:12 [PATCH] rtl2830: add parent for I2C adapter Antti Palosaari
2013-10-21 20:20 ` Antti Palosaari
2013-10-29 21:17 ` Antti Palosaari
2013-10-30 15:16 ` Wolfram Sang
2013-10-30 15:35 ` Antti Palosaari
2013-10-30 15:36 ` Antti Palosaari
2013-10-30 15:45 ` Wolfram Sang
2013-10-30 15:51 ` Antti Palosaari [this message]
2013-10-30 16:02 ` Wolfram Sang
2013-10-30 16:29 ` Antti Palosaari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52712AF4.5020503@iki.fi \
--to=crope@iki.fi \
--cc=khali@linux-fr.org \
--cc=linux-media@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.