From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33529) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbZ4I-0007cw-DB for qemu-devel@nongnu.org; Wed, 30 Oct 2013 12:56:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VbZ4A-0006cS-0P for qemu-devel@nongnu.org; Wed, 30 Oct 2013 12:56:30 -0400 Received: from mail-qa0-x229.google.com ([2607:f8b0:400d:c00::229]:51793) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbZ49-0006cO-Sg for qemu-devel@nongnu.org; Wed, 30 Oct 2013 12:56:21 -0400 Received: by mail-qa0-f41.google.com with SMTP id f11so3893400qae.0 for ; Wed, 30 Oct 2013 09:56:21 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <52713A30.4070502@redhat.com> Date: Wed, 30 Oct 2013 17:56:16 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1382978620-16641-1-git-send-email-pbonzini@redhat.com> <20131029183025.GB25726@dhcp-200-207.str.redhat.com> In-Reply-To: <20131029183025.GB25726@dhcp-200-207.str.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [WIP PATCH 00/24] IDE cleanups, initial work on AHCI rerror/werror=stop List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, stefanha@redhat.com, mst@redhat.com Il 29/10/2013 19:30, Kevin Wolf ha scritto: > Am 28.10.2013 um 17:43 hat Paolo Bonzini geschrieben: >> Hi all, >> >> this is some cleanup to the IDE code that I started long ago >> and picked up again on my flight back from KVM Forum... >> >> The patches clean up the callbacks to prepare for implementing request >> retry for AHCI. After these patches, PIO retry should work for AHCI and >> non-NCQ retry should be very close (you need an implementation of the >> new restart_dma callback). NCQ retry and save/restore is AHCI-specific >> and has to be done separately, similar to how we do it for SCSI already. >> >> Patches 1-4 set up a new (incomplete) testcase. Patches 5-13 are no-op >> cleanups, or so I hope. Patches 14-23 genericize retry and make it >> "just work" for all adapters for PIO. Patch 24 is another cleanup that >> could probably be moved earlier in the series. >> >> Throwing it out since I know Kevin and mst are working on AHCI, to avoid >> doing duplicate work. Patches 2 and 4 are known to be racy and >> incomplete. Extremely light testing, if something breaks tells me and >> I'll look at it. > > You forgot some CCs it seems. You're lucky that I'm reading qemu-devel > today, for the first time in two weeks or so. CCing myself so I can > hopefully have a look tomorrow. While you finish reviewing, I pushed a version that actually boots guests on my github repo's ide-cb branch. I have added a patch to enable restart for the ISA IDE controller; it cannot be tested the same way as the PCI one (no ioapic on -M isapc), but it is less hacky than what I had done for AHCI. Paolo