From: Chad Versace <chad.versace@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>, Ian Romanick <idr@freedesktop.org>
Cc: "Nikkanen, Kimmo" <kimmo.nikkanen@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"gfx-internal-devel@linux.intel.com"
<gfx-internal-devel@linux.intel.com>,
"Hindman, Gavin" <gavin.hindman@intel.com>,
"Barnes, Jesse" <jesse.barnes@intel.com>,
Daniel Vetter <daniel.vetter@intel.com>,
"Parenteau, Paul A" <paul.a.parenteau@intel.com>
Subject: Re: [RFC/Draft] Testing requirements for upstream drm/i915 patches
Date: Wed, 30 Oct 2013 13:32:44 -0700 [thread overview]
Message-ID: <52716CEC.6000102@linux.intel.com> (raw)
In-Reply-To: <CAKMK7uH4Om2FpNVdJ2A9bDRdj7Pda7BFS8MkY78=3r4oCU_zVg@mail.gmail.com>
On 10/30/2013 12:05 PM, Daniel Vetter wrote:
> On Wed, Oct 30, 2013 at 7:11 PM, Ian Romanick <idr@freedesktop.org> wrote:
>>> test coverage of the existing code _before_ starting a feature instead
>>> of when the patches are ready for merging should help a lot, before
>>> everyone is invested into patches already and mounting rebase pain looms
>>> large.
> Yeah, that would be a great way to bring up new people. The problem is
> a bit that on the kernel side we have a few disadvantages compared to
> mesa: We don't have a nice spec and we also don't have a fairly decent
> reference implementation (the nvidia blob). So ime writing kernel
> tests is much more open-ended than reading a gl extension spec and
> just nocking off all the new enums and api interface points.
Writing *meaningful* GL tests is much more open-ended than reading a gl
spec and knocking off each item. To really test some GL features, you
must be exceedingly clever and even have an understanding of the underlying
hardware implementation to test the significant corner cases. In that
sense, it's not too different from writing a kernel test case.
My comment is intended to be positive rather than a negative correction.
The Mesa team frequently succeeds at creating good test coverage of
new GL features despite the difficulty. That fact hopefully confirms it
will be possible for the kernel team too.
next prev parent reply other threads:[~2013-10-30 20:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-30 16:00 [RFC/Draft] Testing requirements for upstream drm/i915 patches Daniel Vetter
2013-10-30 18:11 ` Ian Romanick
2013-10-30 19:05 ` Daniel Vetter
2013-10-30 20:32 ` Chad Versace [this message]
2013-11-13 13:42 ` Rodrigo Vivi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52716CEC.6000102@linux.intel.com \
--to=chad.versace@linux.intel.com \
--cc=daniel.vetter@intel.com \
--cc=daniel@ffwll.ch \
--cc=gavin.hindman@intel.com \
--cc=gfx-internal-devel@linux.intel.com \
--cc=idr@freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jesse.barnes@intel.com \
--cc=kimmo.nikkanen@intel.com \
--cc=paul.a.parenteau@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.