From: Hauke Mehrtens <hauke@hauke-m.de>
To: Johannes Berg <johannes@sipsolutions.net>, backports@vger.kernel.org
Subject: Re: [RFC] backports: replace netlink portid by semantic patch
Date: Wed, 30 Oct 2013 22:11:01 +0100 [thread overview]
Message-ID: <527175E5.6000201@hauke-m.de> (raw)
In-Reply-To: <1382110139-23344-1-git-send-email-johannes@sipsolutions.net>
On 10/18/2013 05:28 PM, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> Introduce the infrastructure to apply semantic patches
> and make use of it for the (frequently breaking) portid
> patch for netlink.
>
> Unfortunately this is significantly slower:
>
> before:
> real 0m14.312s
> user 0m12.144s
> sys 0m1.784s
>
> after:
> real 0m25.932s
> user 0m21.768s
> sys 0m2.932s
>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
> gentree.py | 36 +++
> .../network/0005-netlink-portid.cocci | 25 ++
> .../network/0005-netlink-portid/INFO | 42 ----
> .../0005-netlink-portid/mac80211_hwsim.patch | 24 --
> .../network/0005-netlink-portid/nl80211.patch | 267 ---------------------
> 5 files changed, 61 insertions(+), 333 deletions(-)
> create mode 100644 patches/collateral-evolutions/network/0005-netlink-portid.cocci
> delete mode 100644 patches/collateral-evolutions/network/0005-netlink-portid/INFO
> delete mode 100644 patches/collateral-evolutions/network/0005-netlink-portid/mac80211_hwsim.patch
> delete mode 100644 patches/collateral-evolutions/network/0005-netlink-portid/nl80211.patch
Getting rid of the big patches and replacing them with a semantic patch
is worth the extra time needed.
Would you like to resend it with the other netlink-portid patches (nfc,
ieee80154) also removed or should I add that to the patch.
Hauke
next prev parent reply other threads:[~2013-10-30 21:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-18 15:28 [RFC] backports: replace netlink portid by semantic patch Johannes Berg
2013-10-18 15:48 ` Hauke Mehrtens
2013-10-18 16:52 ` Johannes Berg
2013-10-18 18:13 ` Johannes Berg
2013-10-20 13:39 ` Eliad Peller
2013-10-21 8:02 ` Johannes Berg
2013-10-30 21:11 ` Hauke Mehrtens [this message]
2013-10-30 21:13 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527175E5.6000201@hauke-m.de \
--to=hauke@hauke-m.de \
--cc=backports@vger.kernel.org \
--cc=johannes@sipsolutions.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.