All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chen Gang <gang.chen@asianux.com>
To: Jonas Bonn <jonas@southpole.se>
Cc: linux@openrisc.net,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] openrisc: include: asm: define empty SERIAL_PORT_DFNS in serial.h
Date: Thu, 31 Oct 2013 14:58:45 +0800	[thread overview]
Message-ID: <5271FFA5.1080909@asianux.com> (raw)
In-Reply-To: <5271B83C.50807@asianux.com>

On 10/31/2013 09:54 AM, Chen Gang wrote:
> For some architectures (e.g. openrisc, arc), BASE_BAUD isn't constant
> And SERIAL_PORT_DFNS always use BASE_BAUND, and also all drivers use
> SERIAL_PORT_DFNS to initialize static variables, statically.
> 
> So need define SERIAL_PORT_DFNS as empty to tell drivers they don't
> support SERIAL_PORT_DFNS (mostly like frv and parisc did).
> 
> 
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
>  arch/openrisc/include/asm/serial.h |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/openrisc/include/asm/serial.h b/arch/openrisc/include/asm/serial.h
> index 270a452..254d1ad 100644
> --- a/arch/openrisc/include/asm/serial.h
> +++ b/arch/openrisc/include/asm/serial.h
> @@ -31,6 +31,8 @@
>  
>  #define BASE_BAUD (cpuinfo.clock_frequency/16)
>  
> +#define SERIAL_PORT_DFNS
> +
>  #endif /* __KERNEL__ */
>  
>  #endif /* __ASM_OPENRISC_SERIAL_H */
> 

Oh, sorry, this patch is incorrect, need fix within the driver.

Thanks.
-- 
Chen Gang

      reply	other threads:[~2013-10-31  6:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-31  1:54 [PATCH] openrisc: include: asm: define empty SERIAL_PORT_DFNS in serial.h Chen Gang
2013-10-31  6:58 ` Chen Gang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5271FFA5.1080909@asianux.com \
    --to=gang.chen@asianux.com \
    --cc=jonas@southpole.se \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@openrisc.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.