From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Thu, 31 Oct 2013 10:53:43 +0100 (CET) Received: from nbd.name ([46.4.11.11]:43176 "EHLO nbd.name" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S6817974Ab3JaJxjq0S0P (ORCPT ); Thu, 31 Oct 2013 10:53:39 +0100 Message-ID: <52722851.30302@openwrt.org> Date: Thu, 31 Oct 2013 10:52:17 +0100 From: John Crispin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130116 Icedove/10.0.12 MIME-Version: 1.0 To: Wei Yongjun CC: ralf@linux-mips.org, grant.likely@linaro.org, rob.herring@calxeda.com, yongjun_wei@trendmicro.com.cn, linux-mips@linux-mips.org Subject: Re: [PATCH] MIPS: ralink: fix return value check in rt_timer_probe() References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 38425 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: blogic@openwrt.org Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On 31/10/13 08:51, Wei Yongjun wrote: > From: Wei Yongjun > > In case of error, the function devm_request_and_ioremap() returns NULL > pointer not ERR_PTR(). Fix it by using devm_ioremap_resource() instead > of devm_request_and_ioremap(). > > Signed-off-by: Wei Yongjun Thanks for spotting the bug. Acked-by: John Crispin