All of lore.kernel.org
 help / color / mirror / Atom feed
From: gregory.clement@free-electrons.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: kirkwood: add support for OpenBlocks A7 platform
Date: Thu, 31 Oct 2013 13:54:42 +0100	[thread overview]
Message-ID: <52725312.4090208@free-electrons.com> (raw)
In-Reply-To: <20131031125030.GJ26784@titan.lakedaemon.net>

On 31/10/2013 13:50, Jason Cooper wrote:
> On Thu, Oct 31, 2013 at 10:21:23AM +0100, Thomas Petazzoni wrote:
>> Dear Gregory CLEMENT,
>>
>> On Thu, 31 Oct 2013 10:17:43 +0100, Gregory CLEMENT wrote:
>>
>>>> Strange. 'make dtbs' was working here. What was wrong exactly? Just
>>>> that the unit address (@90000) didn't match the starting address
>>>> 0x1c0000 ?
>>>
>>> The unit address has no special meaning for the device tree it's just a
>>> way to give a unique name to a node right?
>>
>> Yes, that's also my understanding.
> 
> Correct, that's not what caused the error.
> 
>>> So in this case it is not really a problem, but it's just nicer for the
>>> coherency of the information in the dt to have the unit address which match
>>> the starting address.
>>
>> Indeed, it's much better if they match (shame on me for the silly
>> copy/paste), but having then *not* matching should not cause any DTC
>> error, I believe.
>>
>>> I also do a make dtbs ans I didn't get any errors:
>>> $ make dtbs
>>>  [...]
>>>   DTC     arch/arm/boot/dts/kirkwood-openblocks_a6.dtb
>>>   DTC     arch/arm/boot/dts/kirkwood-openblocks_a7.dtb
>>
>> Same here.
> 
> With Thomas' original patch (on top of mvebu/dt, based on v3.12-rc1):

On my side I tested the patch on top on v3.12-rc7. So the difference should
be there.

> 
> $ make kirkwood_defconfig
> $ make dtbs
> ...
>   DTC     arch/arm/boot/dts/kirkwood-openblocks_a6.dtb
>   DTC     arch/arm/boot/dts/kirkwood-openblocks_a7.dtb
> Warning (reg_format): "reg" property in /ocp at f1000000/nand at 3000000/partition at 0 has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1)
> Warning (reg_format): "reg" property in /ocp at f1000000/nand at 3000000/partition at 90000 has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1)
> Warning (reg_format): "reg" property in /ocp at f1000000/nand at 3000000/partition at d4000 has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1)
> Warning (reg_format): "reg" property in /ocp at f1000000/nand at 3000000/partition at f4000 has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1)
> Warning (reg_format): "reg" property in /ocp at f1000000/nand at 3000000/partition at 4f4000 has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1)
> Warning (reg_format): "reg" property in /ocp at f1000000/nand at 3000000/partition at 2214000 has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1)
> Warning (avoid_default_addr_size): Relying on default #address-cells value for /ocp at f1000000/nand at 3000000/partition at 0
> Warning (avoid_default_addr_size): Relying on default #size-cells value for /ocp at f1000000/nand at 3000000/partition at 0
> Warning (avoid_default_addr_size): Relying on default #address-cells value for /ocp at f1000000/nand at 3000000/partition at 90000
> Warning (avoid_default_addr_size): Relying on default #size-cells value for /ocp at f1000000/nand at 3000000/partition at 90000
> Warning (avoid_default_addr_size): Relying on default #address-cells value for /ocp at f1000000/nand at 3000000/partition at d4000
> Warning (avoid_default_addr_size): Relying on default #size-cells value for /ocp at f1000000/nand at 3000000/partition at d4000
> Warning (avoid_default_addr_size): Relying on default #address-cells value for /ocp at f1000000/nand at 3000000/partition at f4000
> Warning (avoid_default_addr_size): Relying on default #size-cells value for /ocp at f1000000/nand at 3000000/partition at f4000
> Warning (avoid_default_addr_size): Relying on default #address-cells value for /ocp at f1000000/nand at 3000000/partition at 4f4000
> Warning (avoid_default_addr_size): Relying on default #size-cells value for /ocp at f1000000/nand at 3000000/partition at 4f4000
> Warning (avoid_default_addr_size): Relying on default #address-cells value for /ocp at f1000000/nand at 3000000/partition at 2214000
> Warning (avoid_default_addr_size): Relying on default #size-cells value for /ocp at f1000000/nand at 3000000/partition at 2214000
> 
> thx,
> 
> Jason.
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 


-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2013-10-31 12:54 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-30 16:55 [PATCH 0/2] Add support for OpenBlocks A7 Thomas Petazzoni
2013-10-30 16:55 ` [PATCH 1/2] ARM: kirkwood: add support for OpenBlocks A7 platform Thomas Petazzoni
2013-10-30 17:04   ` Andrew Lunn
2013-10-30 17:09   ` Gregory CLEMENT
     [not found]   ` <52713B10.9060809@free-electrons.com>
2013-10-30 17:15     ` acked Jason Cooper
2013-10-30 17:20       ` acked Russell King - ARM Linux
2013-10-30 17:26         ` acked Jason Cooper
2013-10-30 17:22       ` acked Gregory CLEMENT
2013-10-30 17:27         ` acked Jason Cooper
2013-10-30 19:57   ` [PATCH 1/2] ARM: kirkwood: add support for OpenBlocks A7 platform Jason Cooper
2013-10-31  8:37     ` Thomas Petazzoni
2013-10-31  9:17       ` Gregory CLEMENT
2013-10-31  9:21         ` Thomas Petazzoni
2013-10-31 12:50           ` Jason Cooper
2013-10-31 12:54             ` Gregory CLEMENT [this message]
2013-10-31 13:20               ` Jason Cooper
2013-10-30 16:55 ` [PATCH 2/2] ARM: kirkwood: enable HIGHMEM in defconfig Thomas Petazzoni
2013-10-30 17:00   ` Andrew Lunn
2013-10-30 17:09   ` Gregory CLEMENT
2013-11-01 15:35   ` Jason Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52725312.4090208@free-electrons.com \
    --to=gregory.clement@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.