Re: [Qemu-devel] [PATCH v5 2/2] vmdk: Implment bdrv_get_specific_info

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1034 bytes --]

On 10/30/2013 08:06 PM, Fam Zheng wrote:
> Implement .bdrv_get_specific_info to return the extent information.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> 
> ---
> v5: Changed 3 lines:
>     - Save cid in vmdk_open. (Kevin)
>     - Report parent_cid in vmdk_get_specific_info.
>     - Rename create_type to create-type in qapi-schema.json.
> 

> +++ b/qapi-schema.json
> @@ -225,6 +225,27 @@
>    } }
>  
>  ##
> +# @ImageInfoSpecificVmdk:
> +#
> +# @create_type: The create type of VMDK image

Mismatch...

> +#
> +# @cid: Content id of image
> +#
> +# @parent-cid: Parent VMDK image's cid
> +#
> +# @extents: List of extent files
> +#
> +# Since: 1.7
> +##
> +{ 'type': 'ImageInfoSpecificVmdk',
> +  'data': {
> +      'create-type': 'str',

...from the actual spelling.

> +      'cid': 'int',
> +      'parent-cid': 'int',
> +      'extents': ['ImageInfo']
> +  } }
> +

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]