From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Thu, 31 Oct 2013 19:55:45 +0100 (CET) Received: from mailout1.w1.samsung.com ([210.118.77.11]:37752 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S6827336Ab3JaSzktN5dO (ORCPT ); Thu, 31 Oct 2013 19:55:40 +0100 Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout1.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MVJ00MPOR8I6MF0@mailout1.w1.samsung.com> for linux-mips@linux-mips.org; Thu, 31 Oct 2013 18:55:31 +0000 (GMT) X-AuditID: cbfec7f4-b7f0a6d000007b1b-fa-5272a7a2dc85 Received: from eusync3.samsung.com ( [203.254.199.213]) by eucpsbgm1.samsung.com (EUCPMTA) with SMTP id 85.EF.31515.2A7A2725; Thu, 31 Oct 2013 18:55:30 +0000 (GMT) Received: from [106.116.147.32] by eusync3.samsung.com (Oracle Communications Messaging Server 7u4-23.01(7.0.4.23.0) 64bit (built Aug 10 2011)) with ESMTPA id <0MVJ00IQRR8I1Q40@eusync3.samsung.com>; Thu, 31 Oct 2013 18:55:30 +0000 (GMT) Message-id: <5272A7A0.7020800@samsung.com> Date: Thu, 31 Oct 2013 19:55:28 +0100 From: Sylwester Nawrocki User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-version: 1.0 To: Stephen Warren Cc: mturquette@linaro.org, linux-arm-kernel@lists.infradead.org, linux@arm.linux.org.uk, jiada_wang@mentor.com, kyungmin.park@samsung.com, laurent.pinchart@ideasonboard.com, linux-kernel@vger.kernel.org, uclinux-dist-devel@blackfin.uclinux.org, linux-mips@linux-mips.org, linux-sh@vger.kernel.org, "linux-next@vger.kernel.org" Subject: Re: [PATCH v7 5/5] clk: Implement clk_unregister() References: <1383076268-8984-1-git-send-email-s.nawrocki@samsung.com> <1383076268-8984-6-git-send-email-s.nawrocki@samsung.com> <5272A24A.30800@wwwdotorg.org> In-reply-to: <5272A24A.30800@wwwdotorg.org> Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrDLMWRmVeSWpSXmKPExsVy+t/xq7qLlhcFGXyaZW3R86fS4mzTG3aL zolL2C02Pb7GanF51xw2iwlTJ7FbHFzYxmgx588UZovbl3ktnk64yGbx6mAbi8XChi/sDjwe Lc09bB4rp3t7zO6Yyepx59oeNo+jK9cyeWxeUu+x+2sTo0ffllWMHp83yXlsnBsawBXFZZOS mpNZllqkb5fAlbHrwxe2gu/cFWu2XGVuYLzK2cXIySEhYCIx4WQfI4QtJnHh3nq2LkYuDiGB pYwS69ZOZwNJCAl8YpR4Od0DxOYV0JLY9rybBcRmEVCVeL92DTOIzSZgKNF7FGKQqECYxNGm n6wQ9YISPybfA6sXAeqd9OwfI8gCZoG3TBKHpvSCFQkLWEvMWHqLBWLzIkaJW7uus4MkOAW0 JRr//QfbwCygI7G/dRobhC0vsXnNW+YJjAKzkCyZhaRsFpKyBYzMqxhFU0uTC4qT0nMN9YoT c4tL89L1kvNzNzFCYujLDsbFx6wOMQpwMCrx8L7oKwoSYk0sK67MPcQowcGsJMIrkgMU4k1J rKxKLcqPLyrNSS0+xMjEwSnVwOhgP99/bc+ve7sKJT+f+3aSK2Rdcf0sV8EXpTtYDx+etvvy U02JSb5X3nV1pM9O8Gwy8Tl1uWXGjhrWskf7JDbnOl5vSg0/3/C/adEFrXnurgVipWUPOk6e eZzGfpA/sDBR71SI2Jrbk8U3dDx6s5rBzd7gfsq9/dW652xM5x+dvLZsUlfMlB9KLMUZiYZa zEXFiQDJURO/fwIAAA== Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 38431 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: s.nawrocki@samsung.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On 31/10/13 19:32, Stephen Warren wrote: > On 10/29/2013 01:51 PM, Sylwester Nawrocki wrote: >> > clk_unregister() is currently not implemented and it is required when >> > a clock provider module needs to be unloaded. >> > >> > Normally the clock supplier module is prevented to be unloaded by >> > taking reference on the module in clk_get(). >> > >> > For cases when the clock supplier module deinitializes despite the >> > consumers of its clocks holding a reference on the module, e.g. when >> > the driver is unbound through "unbind" sysfs attribute, there are >> > empty clock ops added. These ops are assigned temporarily to struct >> > clk and used until all consumers release the clock, to avoid invoking >> > callbacks from the module which just got removed. > > This patch is now in Mike's clk-next and hence next-20131031, and causes > both a WARN and an OOPS when booting the Tegra Dalmore board. (See log > below) > > If I do the following to fix some other issues: > > 1) Apply: > http://www.spinics.net/lists/arm-kernel/msg283619.html > clk: fix boot panic with non-dev-associated clocks > > 2) Merge some Tegra-specific bug-fixes: > https://lkml.org/lkml/2013/10/29/771 > Re: pull request for Tegra clock rework and Tegra124 clock support > > ... then revert this patch a336ed7 "clk: Implement clk_unregister()", > everything works again. Does it still crash when you apply this patch http://www.spinics.net/lists/arm-kernel/msg283550.html ? -- Thanks, Sylwester From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sylwester Nawrocki Date: Thu, 31 Oct 2013 18:55:28 +0000 Subject: Re: [PATCH v7 5/5] clk: Implement clk_unregister() Message-Id: <5272A7A0.7020800@samsung.com> List-Id: References: <1383076268-8984-1-git-send-email-s.nawrocki@samsung.com> <1383076268-8984-6-git-send-email-s.nawrocki@samsung.com> <5272A24A.30800@wwwdotorg.org> In-Reply-To: <5272A24A.30800@wwwdotorg.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On 31/10/13 19:32, Stephen Warren wrote: > On 10/29/2013 01:51 PM, Sylwester Nawrocki wrote: >> > clk_unregister() is currently not implemented and it is required when >> > a clock provider module needs to be unloaded. >> > >> > Normally the clock supplier module is prevented to be unloaded by >> > taking reference on the module in clk_get(). >> > >> > For cases when the clock supplier module deinitializes despite the >> > consumers of its clocks holding a reference on the module, e.g. when >> > the driver is unbound through "unbind" sysfs attribute, there are >> > empty clock ops added. These ops are assigned temporarily to struct >> > clk and used until all consumers release the clock, to avoid invoking >> > callbacks from the module which just got removed. > > This patch is now in Mike's clk-next and hence next-20131031, and causes > both a WARN and an OOPS when booting the Tegra Dalmore board. (See log > below) > > If I do the following to fix some other issues: > > 1) Apply: > http://www.spinics.net/lists/arm-kernel/msg283619.html > clk: fix boot panic with non-dev-associated clocks > > 2) Merge some Tegra-specific bug-fixes: > https://lkml.org/lkml/2013/10/29/771 > Re: pull request for Tegra clock rework and Tegra124 clock support > > ... then revert this patch a336ed7 "clk: Implement clk_unregister()", > everything works again. Does it still crash when you apply this patch http://www.spinics.net/lists/arm-kernel/msg283550.html ? -- Thanks, Sylwester From mboxrd@z Thu Jan 1 00:00:00 1970 From: s.nawrocki@samsung.com (Sylwester Nawrocki) Date: Thu, 31 Oct 2013 19:55:28 +0100 Subject: [PATCH v7 5/5] clk: Implement clk_unregister() In-Reply-To: <5272A24A.30800@wwwdotorg.org> References: <1383076268-8984-1-git-send-email-s.nawrocki@samsung.com> <1383076268-8984-6-git-send-email-s.nawrocki@samsung.com> <5272A24A.30800@wwwdotorg.org> Message-ID: <5272A7A0.7020800@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 31/10/13 19:32, Stephen Warren wrote: > On 10/29/2013 01:51 PM, Sylwester Nawrocki wrote: >> > clk_unregister() is currently not implemented and it is required when >> > a clock provider module needs to be unloaded. >> > >> > Normally the clock supplier module is prevented to be unloaded by >> > taking reference on the module in clk_get(). >> > >> > For cases when the clock supplier module deinitializes despite the >> > consumers of its clocks holding a reference on the module, e.g. when >> > the driver is unbound through "unbind" sysfs attribute, there are >> > empty clock ops added. These ops are assigned temporarily to struct >> > clk and used until all consumers release the clock, to avoid invoking >> > callbacks from the module which just got removed. > > This patch is now in Mike's clk-next and hence next-20131031, and causes > both a WARN and an OOPS when booting the Tegra Dalmore board. (See log > below) > > If I do the following to fix some other issues: > > 1) Apply: > http://www.spinics.net/lists/arm-kernel/msg283619.html > clk: fix boot panic with non-dev-associated clocks > > 2) Merge some Tegra-specific bug-fixes: > https://lkml.org/lkml/2013/10/29/771 > Re: pull request for Tegra clock rework and Tegra124 clock support > > ... then revert this patch a336ed7 "clk: Implement clk_unregister()", > everything works again. Does it still crash when you apply this patch http://www.spinics.net/lists/arm-kernel/msg283550.html ? -- Thanks, Sylwester