From: gerg@uclinux.org (Greg Ungerer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 3/7] ARM: imx: add support code for IMX50 based machines
Date: Fri, 01 Nov 2013 11:59:10 +1000 [thread overview]
Message-ID: <52730AEE.1000408@uclinux.org> (raw)
In-Reply-To: <20131031061041.GC23549@S2101-09.ap.freescale.net>
Hi Shawn,
On 31/10/13 16:10, Shawn Guo wrote:
> On Tue, Oct 29, 2013 at 03:15:53PM +1000, gerg at uclinux.org wrote:
>> +DT_MACHINE_START(IMX50_DT, "Freescale i.MX50 (Device Tree Support)")
>> + .map_io = mx53_map_io,
>> + .init_early = imx53_init_early,
>> + .init_irq = mx53_init_irq,
>> + .handle_irq = imx53_handle_irq,
>> + .init_machine = imx50_dt_init,
>> + .init_late = imx53_init_late,
>> + .dt_compat = imx50_dt_board_compat,
>> + .restart = mxc_restart,
>> +MACHINE_END
>
> The imx53 is a platform that was converted from non-DT to DT. Some of
> these imx53 hooks may not even necessary for imx53 now, since imx53
> supports DT boot only today. So I do not prefer to reuse these imx53
> hooks on the brand new imx50 DT machine. I would suggest to maintain a
> mach-imx50.c and machine descriptor for imx50 with only the necessary
> hooks implemented as local functions inside mach-imx50.c. After imx53
> machine descriptor and hooks gets cleaned up, we can look at how we can
> consolidate these descriptors if they are pretty much in common.
With the current support I could drop .init_early and .init_late
I believe. All the other mx53 functions are needed to successfully
boot.
imx53_handle_irq is easy to fix, it is just defined to be
tzic_handle_irq anyway.
mx53_map_io and mx53_init_irq are coded in mm-imx5.c. They look strait
forward. Do you want me to create imx50 specific versions in there?
Regards
Greg
next prev parent reply other threads:[~2013-11-01 1:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-29 5:15 [PATCHv2 0/7] ARM: imx: add IMX50 SoC support gerg at uclinux.org
2013-10-29 5:15 ` [PATCHv2 1/7] ARM: imx: add debug uart support for IMX50 SoC gerg at uclinux.org
2013-10-29 5:15 ` [PATCHv2 2/7] ARM: imx: add clocking support code for the " gerg at uclinux.org
2013-10-29 17:43 ` Jason Cooper
2013-10-29 5:15 ` [PATCHv2 3/7] ARM: imx: add support code for IMX50 based machines gerg at uclinux.org
2013-10-29 15:40 ` Jason Cooper
2013-10-30 2:02 ` Greg Ungerer
2013-10-31 6:10 ` Shawn Guo
2013-11-01 1:59 ` Greg Ungerer [this message]
2013-11-01 8:21 ` Shawn Guo
2013-11-04 0:11 ` Greg Ungerer
2013-10-29 5:15 ` [PATCHv2 4/7] ARM: imx: allow configuration of the IMX50 SoC gerg at uclinux.org
2013-10-29 5:15 ` [PATCHv2 5/7] ARM: dts: imx: add device tree pin definitions for the IMX50 gerg at uclinux.org
2013-10-29 5:15 ` [PATCHv2 6/7] ARM: dts: imx: add IMX50 SoC device tree gerg at uclinux.org
2013-10-29 5:15 ` [PATCHv2 7/7] ARM: dts: imx: add device tree support for Freescale imx50evk board gerg at uclinux.org
2013-11-04 9:15 ` Shawn Guo
2013-10-29 19:20 ` [PATCHv2 0/7] ARM: imx: add IMX50 SoC support Jason Cooper
2013-10-30 2:02 ` Greg Ungerer
2013-10-31 5:59 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52730AEE.1000408@uclinux.org \
--to=gerg@uclinux.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.