All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josh Wu <josh.wu@atmel.com>
To: Wei Yongjun <weiyj.lk@gmail.com>, <jic23@kernel.org>,
	<grant.likely@linaro.org>, <rob.herring@calxeda.com>,
	<maxime.ripard@free-electrons.com>, <lars@metafoo.de>,
	<ludovic.desroches@atmel.com>
Cc: <yongjun_wei@trendmicro.com.cn>, <linux-iio@vger.kernel.org>
Subject: Re: [PATCH -next] iio: at91: fix error return code in at91_adc_probe()
Date: Fri, 1 Nov 2013 16:32:13 +0800	[thread overview]
Message-ID: <5273670D.7070705@atmel.com> (raw)
In-Reply-To: <CAPgLHd_whWvPuHTCGdQkZa2fbra=U1nRBvBCyd9azUzS8_XLNg@mail.gmail.com>

Hi, Yongjun

On 10/30/2013 1:20 PM, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fix to return -ENODEV instead of 0 if non-TSMR adc don't
> support, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

Thanks and
Acked-by: Josh Wu <josh.wu@atmel.com>

Best Regards,
Josh Wu

> ---
>   drivers/iio/adc/at91_adc.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c
> index 17df749..5b1aa02 100644
> --- a/drivers/iio/adc/at91_adc.c
> +++ b/drivers/iio/adc/at91_adc.c
> @@ -1047,6 +1047,7 @@ static int at91_adc_probe(struct platform_device *pdev)
>   	} else {
>   		if (!st->caps->has_tsmr) {
>   			dev_err(&pdev->dev, "We don't support non-TSMR adc\n");
> +			ret = -ENODEV;
>   			goto error_disable_adc_clk;
>   		}
>   
>


  reply	other threads:[~2013-11-01  8:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-30  5:20 [PATCH -next] iio: at91: fix error return code in at91_adc_probe() Wei Yongjun
2013-11-01  8:32 ` Josh Wu [this message]
2013-11-02 13:10   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5273670D.7070705@atmel.com \
    --to=josh.wu@atmel.com \
    --cc=grant.likely@linaro.org \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=ludovic.desroches@atmel.com \
    --cc=maxime.ripard@free-electrons.com \
    --cc=rob.herring@calxeda.com \
    --cc=weiyj.lk@gmail.com \
    --cc=yongjun_wei@trendmicro.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.