From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35730) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VcBgP-0002eg-6L for qemu-devel@nongnu.org; Fri, 01 Nov 2013 06:10:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VcBgK-0000mz-Ag for qemu-devel@nongnu.org; Fri, 01 Nov 2013 06:10:25 -0400 Received: from isrv.corpit.ru ([86.62.121.231]:55732) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VcBgK-0000lX-1c for qemu-devel@nongnu.org; Fri, 01 Nov 2013 06:10:20 -0400 Message-ID: <52737E08.4050908@msgid.tls.msk.ru> Date: Fri, 01 Nov 2013 14:10:16 +0400 From: Michael Tokarev MIME-Version: 1.0 References: <20131026090745.14894.51156.reportbug@localhost> <526B8921.3060605@msgid.tls.msk.ru> <20131026184443.7b1293d8@wiggum> <52737541.3030802@msgid.tls.msk.ru> <20131101105432.5f45f689@wiggum> In-Reply-To: <20131101105432.5f45f689@wiggum> Content-Type: multipart/mixed; boundary="------------020500090508080709060103" Subject: [Qemu-devel] [PATCH] qemu: Broken -smb with latest SAMBA package. (Unsupported security=share option) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Michael_B=FCsch?= , 727756@bugs.debian.org Cc: Jan Kiszka , qemu-devel This is a multi-part message in MIME format. --------------020500090508080709060103 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable 01.11.2013 13:54, Michael B=FCsch wrote: > On Fri, 01 Nov 2013 13:32:49 +0400 > Michael Tokarev wrote: > >> That looks right. Are you okay adding your Signed-off-by to the patch >> you initially submitted? If yes, I'll make a formal patch submission >> upstream. > > Here you go. Thank you! Adding Jan as slirp maintainer, and my Reviewed-by: Michael Tokarev If Jan picks it up, that's fine. If not, I think it can go to the trivial patches queue. Jan, if you missed context, it is in http://bugs.debian.org/727756 It is not the first time this issue pops up on qemu-devel@ /mjt --------------020500090508080709060103 Content-Type: text/x-patch; name="fix-smb-security-share.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="fix-smb-security-share.patch" From: Michael Buesch Subject: [PATCH] qemu/slirp: Fix SMB security configuration on newer samba versions The smb.conf automatically generated by qemu's -smb option fails on current samba, because smbd rejects the security=share option with the following warning: > WARNING: Ignoring invalid value 'share' for parameter 'security' Which makes it fall back to security=user without guest login. This results in being unable to login to the samba server from the guest OS. This fixes it by selecting 'user' explicitly and mapping unknown users to guest logins. Signed-off-by: Michael Buesch --- Index: qemu-1.6.0+dfsg/net/slirp.c =================================================================== --- qemu-1.6.0+dfsg.orig/net/slirp.c +++ qemu-1.6.0+dfsg/net/slirp.c @@ -529,7 +529,8 @@ static int slirp_smb(SlirpState* s, cons "state directory=%s\n" "log file=%s/log.smbd\n" "smb passwd file=%s/smbpasswd\n" - "security = share\n" + "security = user\n" + "map to guest = Bad User\n" "[qemu]\n" "path=%s\n" "read only=no\n" --------------020500090508080709060103--