From mboxrd@z Thu Jan 1 00:00:00 1970 From: srinivas kandagatla Subject: Re: [PATCH v5 1/4] i2c: busses: i2c-st: Add ST I2C controller Date: Fri, 1 Nov 2013 12:50:25 +0000 Message-ID: <5273A391.5000302@st.com> References: <1381754813-4679-1-git-send-email-maxime.coquelin@st.com> <1381754813-4679-2-git-send-email-maxime.coquelin@st.com> <20131016151419.GA14104@ns203013.ovh.net> <525F915D.9020501@st.com> <525FAEED.7030207@st.com> <20131017141957.GE14104@ns203013.ovh.net> <525FF498.3060202@st.com> <1382021369.4093.44.camel@weser.hi.pengutronix.de> <5260EFDC.804@st.com> <526E7C8C.8080603@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <526E7C8C.8080603-qxv4g6HH51o@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Maxime Coquelin Cc: Lucas Stach , Jean-Christophe PLAGNIOL-VILLARD , Mark Rutland , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Ian Campbell , Russell King , Pawel Moll , Wolfram Sang , Stephen Warren , "linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Rob Herring , Stephen GALLIMORE , Stuart MENEFY , "linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Rob Landley , Grant Likely , Lee Jones , Gabriel FERNANDEZ List-Id: linux-i2c@vger.kernel.org On 28/10/13 15:02, Maxime Coquelin wrote: >> >> 6> IMHO, the compatible string should be "vendor,-" >> rather than first SoC. > I agree. > In this case, we add support to revision 4 of SSC IP. Its not the revision its name of the new IP which is SSC4. However this driver is also compatible with old SSC IP, so It would be nice to have something like two compatible strings "st,comms-ssc-i2c" and "st,comms-ssc4-i2c" Thanks, srini > > Is "st,comms-ssc-v4" okay? From mboxrd@z Thu Jan 1 00:00:00 1970 From: srinivas.kandagatla@st.com (srinivas kandagatla) Date: Fri, 1 Nov 2013 12:50:25 +0000 Subject: [PATCH v5 1/4] i2c: busses: i2c-st: Add ST I2C controller In-Reply-To: <526E7C8C.8080603@st.com> References: <1381754813-4679-1-git-send-email-maxime.coquelin@st.com> <1381754813-4679-2-git-send-email-maxime.coquelin@st.com> <20131016151419.GA14104@ns203013.ovh.net> <525F915D.9020501@st.com> <525FAEED.7030207@st.com> <20131017141957.GE14104@ns203013.ovh.net> <525FF498.3060202@st.com> <1382021369.4093.44.camel@weser.hi.pengutronix.de> <5260EFDC.804@st.com> <526E7C8C.8080603@st.com> Message-ID: <5273A391.5000302@st.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 28/10/13 15:02, Maxime Coquelin wrote: >> >> 6> IMHO, the compatible string should be "vendor,-" >> rather than first SoC. > I agree. > In this case, we add support to revision 4 of SSC IP. Its not the revision its name of the new IP which is SSC4. However this driver is also compatible with old SSC IP, so It would be nice to have something like two compatible strings "st,comms-ssc-i2c" and "st,comms-ssc4-i2c" Thanks, srini > > Is "st,comms-ssc-v4" okay? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752632Ab3KANBJ (ORCPT ); Fri, 1 Nov 2013 09:01:09 -0400 Received: from eu1sys200aog101.obsmtp.com ([207.126.144.111]:44139 "EHLO eu1sys200aog101.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751646Ab3KANBG (ORCPT ); Fri, 1 Nov 2013 09:01:06 -0400 Message-ID: <5273A391.5000302@st.com> Date: Fri, 1 Nov 2013 12:50:25 +0000 From: srinivas kandagatla User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130308 Thunderbird/17.0.4 MIME-Version: 1.0 To: Maxime Coquelin Cc: Lucas Stach , Jean-Christophe PLAGNIOL-VILLARD , Mark Rutland , "devicetree@vger.kernel.org" , Ian Campbell , Russell King , Pawel Moll , Wolfram Sang , Stephen Warren , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Rob Herring , Stephen GALLIMORE , Stuart MENEFY , "linux-i2c@vger.kernel.org" , Rob Landley , Grant Likely , Lee Jones , Gabriel FERNANDEZ , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v5 1/4] i2c: busses: i2c-st: Add ST I2C controller References: <1381754813-4679-1-git-send-email-maxime.coquelin@st.com> <1381754813-4679-2-git-send-email-maxime.coquelin@st.com> <20131016151419.GA14104@ns203013.ovh.net> <525F915D.9020501@st.com> <525FAEED.7030207@st.com> <20131017141957.GE14104@ns203013.ovh.net> <525FF498.3060202@st.com> <1382021369.4093.44.camel@weser.hi.pengutronix.de> <5260EFDC.804@st.com> <526E7C8C.8080603@st.com> In-Reply-To: <526E7C8C.8080603@st.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.65.51.59] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/10/13 15:02, Maxime Coquelin wrote: >> >> 6> IMHO, the compatible string should be "vendor,-" >> rather than first SoC. > I agree. > In this case, we add support to revision 4 of SSC IP. Its not the revision its name of the new IP which is SSC4. However this driver is also compatible with old SSC IP, so It would be nice to have something like two compatible strings "st,comms-ssc-i2c" and "st,comms-ssc4-i2c" Thanks, srini > > Is "st,comms-ssc-v4" okay?