All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Duan Jiong <duanj.fnst@cn.fujitsu.com>, acme@ghostprotocols.net
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/net: replace IS_ERR and PTR_ERR with PTR_ERR_OR_ZERO
Date: Fri, 01 Nov 2013 17:38:42 +0400	[thread overview]
Message-ID: <5273AEE2.2010005@cogentembedded.com> (raw)
In-Reply-To: <1383300016-5947-1-git-send-email-duanj.fnst@cn.fujitsu.com>

Hello.

On 01-11-2013 14:00, Duan Jiong wrote:

> This patch fixes coccinelle error regarding usage of IS_ERR and
> PTR_ERR instead of PTR_ERR_OR_ZERO.

> Signed-off-by: Duan Jiong <duanj.fnst@cn.fujitsu.com>
> ---
>   drivers/net/appletalk/ipddp.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)

> diff --git a/drivers/net/appletalk/ipddp.c b/drivers/net/appletalk/ipddp.c
> index 10d0dba..78f06cb 100644
> --- a/drivers/net/appletalk/ipddp.c
> +++ b/drivers/net/appletalk/ipddp.c
> @@ -312,9 +312,7 @@ module_param(ipddp_mode, int, 0);
>   static int __init ipddp_init_module(void)
>   {
>   	dev_ipddp = ipddp_init();
> -        if (IS_ERR(dev_ipddp))
> -                return PTR_ERR(dev_ipddp);
> -	return 0;
> +        return PTR_ERR_OR_ZERO(dev_ipddp);

    Indent with a tab, please.

WBR, Sergei


      reply	other threads:[~2013-11-01 13:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-01 10:00 [PATCH] drivers/net: replace IS_ERR and PTR_ERR with PTR_ERR_OR_ZERO Duan Jiong
2013-11-01 13:38 ` Sergei Shtylyov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5273AEE2.2010005@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=acme@ghostprotocols.net \
    --cc=duanj.fnst@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.