Re: [PATCH] nfs: fix oops when trying to set SELinux label

[Dave Quigley <dpquigl@davequigley.com>]

On 11/1/2013 12:50 PM, Myklebust, Trond wrote:
> On Fri, 2013-11-01 at 12:02 -0400, Jeff Layton wrote:
>> It looks like _nfs4_get_security_label() has the same problem, but I've
>> so far been unable to get it to be called, so I didn't patch it. It
>> seems like getxattr does some special stuff for SELinux labels that
>> cause them only to ever be fetched once.
>>
>> Is there some trick to it?
>>
> 
> Doesn't 'ls -Z' cause them to security label to be read again?
> 
> Either way, the fix is clearly needed, so I've added the patch, and Cced
> stable.
> 
> Cheers
>    Trond
> 

ls -Z will only cause the label to be reread if its no longer valid in
the NFSv4 cache. Otherwise it will use the in-core inode value and
return that.