Re: [PATCH] nfs: set security label when revalidating inode

[Dave Quigley <dpquigl@davequigley.com>]

On 11/2/2013 6:57 AM, Jeff Layton wrote:
> Currently, we fetch the security label when revalidating an inode's
> attributes, but don't apply it. This is in contrast to the readdir()
> codepath where we do apply label changes.
>
> Cc: Dave Quigley <dpquigl@davequigley.com>
> Signed-off-by: Jeff Layton <jlayton@redhat.com>
> ---
>   fs/nfs/inode.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c
> index 4bc7538..6ae6160 100644
> --- a/fs/nfs/inode.c
> +++ b/fs/nfs/inode.c
> @@ -923,6 +923,8 @@ __nfs_revalidate_inode(struct nfs_server *server, struct inode *inode)
>   	if (nfsi->cache_validity & NFS_INO_INVALID_ACL)
>   		nfs_zap_acl_cache(inode);
>
> +	nfs_setsecurity(inode, fattr, label);
> +
>   	dfprintk(PAGECACHE, "NFS: (%s/%Ld) revalidation complete\n",
>   		inode->i_sb->s_id,
>   		(long long)NFS_FILEID(inode));
>


I'm pretty sure (almost 100000%) that this was originally in the patch 
set and it got lost somewhere. So You have an ACK from me on it.

Dave