From: Johannes Sixt <j6t@kdbg.org>
To: Sebastian Schuberth <sschuberth@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
msysGit Mailinglist <msysgit@googlegroups.com>
Subject: Re: [PATCH 2/3] Windows: a test_cmp that is agnostic to random LF <> CRLF conversions
Date: Sun, 03 Nov 2013 09:32:00 +0100 [thread overview]
Message-ID: <52760A00.4080208@kdbg.org> (raw)
In-Reply-To: <CAHGBnuOHHAZUD_1WWu+WrAYKB1f0BonztbAFzVqhxP0bjAkyfw@mail.gmail.com>
Am 02.11.2013 21:47, schrieb Sebastian Schuberth:
> So maybe it's a good point now to also change the MINGW prerequisite
> name to MSYS as part of your patch, and then name the functions more
> appropriately?
It's too late. The series is already in master, and I see no point in a
follow-up patch of this kind as long as there is no additional benefit.
-- Hannes
--
--
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.
You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en
---
You received this message because you are subscribed to the Google Groups "msysGit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
next prev parent reply other threads:[~2013-11-03 8:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-26 19:17 [PATCH 0/3] Fix tests on Windows caused by random CRLF output Johannes Sixt
2013-10-26 19:17 ` [PATCH 1/3] t5300-pack-object: do not compare binary data using test_cmp Johannes Sixt
2013-10-26 19:17 ` [PATCH 2/3] Windows: a test_cmp that is agnostic to random LF <> CRLF conversions Johannes Sixt
2013-11-02 20:33 ` Sebastian Schuberth
2013-11-02 20:40 ` Johannes Sixt
2013-11-02 20:47 ` Sebastian Schuberth
2013-11-03 8:32 ` Johannes Sixt [this message]
2013-10-26 19:17 ` [PATCH 3/3] tests: undo special treatment of CRLF for Windows Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52760A00.4080208@kdbg.org \
--to=j6t@kdbg.org \
--cc=git@vger.kernel.org \
--cc=msysgit@googlegroups.com \
--cc=sschuberth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.