From mboxrd@z Thu Jan 1 00:00:00 1970 From: Igor Grinberg Subject: Re: [PATCH] ARM: OMAP2+: smsc911x: fix return value check in gpmc_smsc911x_init() Date: Sun, 03 Nov 2013 11:50:13 +0200 Message-ID: <52761C55.5080609@compulab.co.il> References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from softlayer.compulab.co.il ([50.23.254.55]:43561 "EHLO compulab.co.il" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752083Ab3KCJua (ORCPT ); Sun, 3 Nov 2013 04:50:30 -0500 In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Wei Yongjun Cc: khilman@deeprootsystems.com, tony@atomide.com, linux@arm.linux.org.uk, yongjun_wei@trendmicro.com.cn, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org On 10/25/13 11:31, Wei Yongjun wrote: > From: Wei Yongjun > > In case of error, the function platform_device_register_resndata() > returns ERR_PTR() and never returns NULL. The NULL test in the return > value check should be replaced with IS_ERR(). > > Signed-off-by: Wei Yongjun Acked-by: Igor Grinberg > --- > arch/arm/mach-omap2/gpmc-smsc911x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-omap2/gpmc-smsc911x.c b/arch/arm/mach-omap2/gpmc-smsc911x.c > index ef99011..2757504 100644 > --- a/arch/arm/mach-omap2/gpmc-smsc911x.c > +++ b/arch/arm/mach-omap2/gpmc-smsc911x.c > @@ -83,7 +83,7 @@ void __init gpmc_smsc911x_init(struct omap_smsc911x_platform_data *gpmc_cfg) > pdev = platform_device_register_resndata(NULL, "smsc911x", gpmc_cfg->id, > gpmc_smsc911x_resources, ARRAY_SIZE(gpmc_smsc911x_resources), > &gpmc_smsc911x_config, sizeof(gpmc_smsc911x_config)); > - if (!pdev) { > + if (IS_ERR(pdev)) { > pr_err("Unable to register platform device\n"); > gpio_free(gpmc_cfg->gpio_reset); > goto free2; > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Regards, Igor. From mboxrd@z Thu Jan 1 00:00:00 1970 From: grinberg@compulab.co.il (Igor Grinberg) Date: Sun, 03 Nov 2013 11:50:13 +0200 Subject: [PATCH] ARM: OMAP2+: smsc911x: fix return value check in gpmc_smsc911x_init() In-Reply-To: References: Message-ID: <52761C55.5080609@compulab.co.il> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 10/25/13 11:31, Wei Yongjun wrote: > From: Wei Yongjun > > In case of error, the function platform_device_register_resndata() > returns ERR_PTR() and never returns NULL. The NULL test in the return > value check should be replaced with IS_ERR(). > > Signed-off-by: Wei Yongjun Acked-by: Igor Grinberg > --- > arch/arm/mach-omap2/gpmc-smsc911x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-omap2/gpmc-smsc911x.c b/arch/arm/mach-omap2/gpmc-smsc911x.c > index ef99011..2757504 100644 > --- a/arch/arm/mach-omap2/gpmc-smsc911x.c > +++ b/arch/arm/mach-omap2/gpmc-smsc911x.c > @@ -83,7 +83,7 @@ void __init gpmc_smsc911x_init(struct omap_smsc911x_platform_data *gpmc_cfg) > pdev = platform_device_register_resndata(NULL, "smsc911x", gpmc_cfg->id, > gpmc_smsc911x_resources, ARRAY_SIZE(gpmc_smsc911x_resources), > &gpmc_smsc911x_config, sizeof(gpmc_smsc911x_config)); > - if (!pdev) { > + if (IS_ERR(pdev)) { > pr_err("Unable to register platform device\n"); > gpio_free(gpmc_cfg->gpio_reset); > goto free2; > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Regards, Igor.