From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [BUG] Bugs during building 4.3.1 Date: Sun, 3 Nov 2013 18:24:31 +0000 Message-ID: <527694DF.3050107@citrix.com> References: <00d401ced8be$d7289530$8579bf90$@net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2132008974174894232==" Return-path: In-Reply-To: <00d401ced8be$d7289530$8579bf90$@net> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: David Denny Cc: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org --===============2132008974174894232== Content-Type: multipart/alternative; boundary="------------060005080508050502030700" --------------060005080508050502030700 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit On 03/11/13 18:02, David Denny wrote: > > Hi! > > > > Thanks for the great software! I use it constantly. Thought I'd let > you know of a few issues I ran into. #3 might be pretty easy to fix. > > > > 1. No spaces allowed in the base directory path! I guess some > quotes are missing on variables in the makefiles. At least this is a > "known limitation." > Spaces in paths are generally frowned upon. Having said that, it is probably something worth fixing if you can identify what is at fault. > > > 2. Configuration process does not check for openssl and x11, > which I believe are both required. > How are you building qemu upstream? It is certainly not expected to be used with x11 enabled. If you are using the defaults as present in Xen 4.3.1 then we really do have some fixing to do. > > > 3. APPEND_LIB doesn't carry through to all the makefiles. > This looks plausible. If I remember correctly, the idea was always to fault in APPEND_LIB to new bits of the build system as and when needed. I suppose you have come across this because of x11 and openssl ? To submit patches, you should follow the instructions at http://wiki.xen.org/wiki/Submitting_Xen_Patches - particularity "Signing off a patch" ~Andrew > > > My openssl and x11 libraries are in non-standard locations (not in > /usr/X11 or /usr/openssl). > > I've provided three very trivial patches that I hope will be more > illustrative than my typing, but they are probably not production grade. > > I applied them prior to configuration and got a clean build. > > > > Best regards, > > > > David > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel --------------060005080508050502030700 Content-Type: text/html; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit
On 03/11/13 18:02, David Denny wrote:

Hi!

 

Thanks for the great software!  I use it constantly.  Thought I’d let you know of a few issues I ran into.  #3 might be pretty easy to fix.

 

1.       No spaces allowed in the base directory path!   I guess some quotes are missing on variables in the makefiles.  At least this is a “known limitation.”


Spaces in paths are generally frowned upon.  Having said that, it is probably something worth fixing if you can identify what is at fault.

 

2.       Configuration process does not check for openssl and x11, which I believe are both required.


How are you building qemu upstream?  It is certainly not expected to be used with x11 enabled.  If you are using the defaults as present in Xen 4.3.1 then we really do have some fixing to do.

 

3.       APPEND_LIB doesn’t carry through to all the makefiles.


This looks plausible.  If I remember correctly, the idea was always to fault in APPEND_LIB to new bits of the build system as and when needed.  I suppose you have come across this because of x11 and openssl ?

To submit patches, you should follow the instructions at http://wiki.xen.org/wiki/Submitting_Xen_Patches - particularity "Signing off a patch"

~Andrew

 

My openssl and x11 libraries are in non-standard locations (not in /usr/X11 or /usr/openssl).

I’ve provided three very trivial patches that I hope will be more illustrative than my typing, but they are probably not production grade. 

I applied them prior to configuration and got a clean build.

 

Best regards,

 

David



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--------------060005080508050502030700-- --===============2132008974174894232== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============2132008974174894232==--