From: Daniel Borkmann <dborkman@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: davem@davemloft.net, edumazet@google.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Petr Matousek <pmatouse@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH net] net: flow_dissector: fail on evil iph->ihl
Date: Sun, 03 Nov 2013 23:18:22 +0100 [thread overview]
Message-ID: <5276CBAE.8010301@redhat.com> (raw)
In-Reply-To: <1383289270-18952-1-git-send-email-jasowang@redhat.com>
On 11/01/2013 08:01 AM, Jason Wang wrote:
> We don't validate iph->ihl which may lead a dead loop if we meet a IPIP
> skb whose iph->ihl is zero. Fix this by failing immediately when iph->ihl
> is evil (less than 5).
>
> This issue were introduced by commit ec5efe7946280d1e84603389a1030ccec0a767ae
> (rps: support IPIP encapsulation).
>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Petr Matousek <pmatouse@redhat.com>
> Cc: Michael S. Tsirkin <mst@redhat.com>
> Cc: Daniel Borkmann <dborkman@redhat.com>
> Signed-off-by: Jason Wang <jasowang@redhat.com>
Sorry, a bit late as I was offline last 4 days, but fwiw:
Acked-by: Daniel Borkmann <dborkman@redhat.com>
prev parent reply other threads:[~2013-11-03 22:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-01 7:01 [PATCH net] net: flow_dissector: fail on evil iph->ihl Jason Wang
2013-11-01 9:48 ` Eric Dumazet
2013-11-01 16:29 ` Ben Hutchings
2013-11-02 6:16 ` David Miller
2013-11-02 20:22 ` Michael S. Tsirkin
2013-11-03 22:18 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5276CBAE.8010301@redhat.com \
--to=dborkman@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pmatouse@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.