From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nate Studer Subject: Re: [PATCH 1/2] Fix sched_priv corruption in ARINC653 alloc_vdata. Date: Sun, 3 Nov 2013 18:07:22 -0500 Message-ID: <5276D72A.5090208@dornerworks.com> References: <1383252473-3067-1-git-send-email-nate.studer@dornerworks.com> <1383252473-3067-2-git-send-email-nate.studer@dornerworks.com> <5273B266.1050504@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5273B266.1050504@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper Cc: george.dunlap@eu.citrix.com, smartin@milliways.cl, robert.vanvossen@dornerworks.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 11/1/2013 9:53 AM, Andrew Cooper wrote: > On 31/10/13 20:47, Nathan Studer wrote: >> From: Nathan Studer >> >> The ARINC653 scheduler was directly assigning and manipulating >> the sched_priv field of a vcpu in its alloc_vdata function. >> >> When creating a cpu pool, this resulted in the corruption >> of the sched_priv field of the vcpu, which was then passed >> to the initial scheduler's free_vdata function with >> disastrous results. >> >> Signed-off-by: Nathan Studer > > This looks sane. > > Reviewed-by: Andrew Cooper > > You have one line of misc whitespace change. Given the extent of > trailing whitespace in the file, it might be worth having a separate > patch in the series which fixes all the whitespace at once. Along with > that, it would be kind to put a "Local variables" block in as well (see > the bottom of sched.h as an example). These patches just fix the immediate problem of the hypervisor crashing when using the arinc653 scheduler in cpu pools. I expect some more patches in the near future to get pools fully working with the arinc653 scheduler, and since I agree with your assessment, I can address this then. Thanks for suggesting it.