From: Pekka Enberg <penberg@iki.fi>
To: Ying-Shiuan Pan <yingshiuan.pan@gmail.com>, kvm@vger.kernel.org
Cc: yspan@itri.org.tw, penberg@kernel.org, levinsasha928@gmail.com,
asias.hejun@gmail.com
Subject: Re: [PATCH 0/2] kvm tools: fix vhost-net broken since fa7226f88012713a73d0cba4955444ea109e9458
Date: Mon, 04 Nov 2013 10:41:20 +0200 [thread overview]
Message-ID: <52775DB0.1040309@iki.fi> (raw)
In-Reply-To: <1383274260-26739-1-git-send-email-yingshiuan.pan@gmail.com>
On 11/01/2013 04:50 AM, Ying-Shiuan Pan wrote:
> These patch series fix 2 vhost-net problems. There were 2 problems after
> commit fa7226f88012713a73d0cba4955444ea109e9458.
> (1) vhost-net requires tap_fd for VHOST_SET_BACKEND, but opening tap device
> was postponed to VIRTIO_CONFIG_S_DRIVER_OK. The wrong order of initialization
> caused vhost-net used a invalid tap_fd for ioctl.
> (2) virtio-net of kvm tool started to support mergeable rx buffers since
> commit 8c2684de6fb1afc95321e7e0f30550acdcc08186, but kvm tool did not tell
> vhost-net that he is using mergeable rx buffers.
>
> test script:
> $ sudo ./lkvm run --kernel ../../arch/x86/boot/bzImage --no-dhcp --net mode=tap,vhost=1
>
> Ying-Shiuan Pan (2):
> kvm tools: virtio-net has to open tap device before vhost-net init.
> kvm tools: vhost-net: setup mergeable rx buffers feature
>
> tools/kvm/virtio/net.c | 54 +++++++++++++++++++++++++++-----------------------
> 1 file changed, 29 insertions(+), 25 deletions(-)
>
Asias, Sasha?
prev parent reply other threads:[~2013-11-04 8:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-01 2:50 [PATCH 0/2] kvm tools: fix vhost-net broken since fa7226f88012713a73d0cba4955444ea109e9458 Ying-Shiuan Pan
2013-11-01 2:50 ` [PATCH 1/2] kvm tools: virtio-net has to open tap device before vhost-net init Ying-Shiuan Pan
2013-11-01 2:51 ` [PATCH 2/2] kvm tools: vhost-net: setup mergeable rx buffers feature Ying-Shiuan Pan
2013-11-04 8:41 ` Pekka Enberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52775DB0.1040309@iki.fi \
--to=penberg@iki.fi \
--cc=asias.hejun@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
--cc=penberg@kernel.org \
--cc=yingshiuan.pan@gmail.com \
--cc=yspan@itri.org.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.