From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: Nicholas Mc Guire <hofrat@osadl.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Hans Verkuil <hans.verkuil@cisco.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] [media] s5k6aa: set usleep_range greater 0
Date: Tue, 13 Dec 2016 16:10:09 +0200 [thread overview]
Message-ID: <5277658.1FioEDcST1@avalon> (raw)
In-Reply-To: <ae02dfc1-39b9-f7f7-5168-d00e4ad75db7@samsung.com>
Hi Sylwester,
On Tuesday 13 Dec 2016 13:38:52 Sylwester Nawrocki wrote:
> On 12/13/2016 02:58 AM, Nicholas Mc Guire wrote:
> > As this is not in atomic context and it does not seem like a critical
> > timing setting a range of 1ms allows the timer subsystem to optimize
> > the hrtimer here.
> >
> > Fixes: commit bfa8dd3a0524 ("[media] v4l: Add v4l2 subdev driver for
> > S5K6AAFX sensor") Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
> > ---
>
> Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
>
> I'm not sure the "Fixes" tag is needed here.
>
> > Patch is against 4.9.0 (localversion-next is next-20161212)
>
> Ideally patches for the media subsystem should be normally based on
> master branch of the media tree (git://linuxtv.org/media_tree.git).
As pointed out by Ian Arkver, the datasheet states the delay should be >50µs.
Would it make sense to reduce the sleep duration to (3000, 4000) for instance
(or possibly even lower), instead of increasing it ?
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2016-12-13 14:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20161213015743epcas3p19867fa74e5ffe2974364d317d9b494f6@epcas3p1.samsung.com>
2016-12-13 1:58 ` [PATCH RFC] [media] s5k6aa: set usleep_range greater 0 Nicholas Mc Guire
2016-12-13 9:43 ` Sakari Ailus
2016-12-13 10:10 ` Ian Arkver
2016-12-13 10:54 ` Sakari Ailus
2016-12-13 12:38 ` Sylwester Nawrocki
2016-12-13 14:10 ` Laurent Pinchart [this message]
2016-12-13 14:53 ` Sylwester Nawrocki
2016-12-15 1:14 ` Nicholas Mc Guire
2016-12-15 17:45 ` Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5277658.1FioEDcST1@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=hans.verkuil@cisco.com \
--cc=hofrat@osadl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.