Re: [Patch] Call sched_destroy_domain before cpupool_rm_domain.

[Andrew Cooper <andrew.cooper3@citrix.com>]

On 04/11/13 06:30, Juergen Gross wrote:
> On 04.11.2013 04:03, Nathan Studer wrote:
>> From: Nathan Studer <nate.studer@dornerworks.com>
>>
>> The domain destruction code, removes a domain from its cpupool
>> before attempting to destroy its scheduler information.  Since
>> the scheduler framework uses the domain's cpupool information
>> to decide on which scheduler ops to use, this results in the
>> the wrong scheduler's destroy domain function being called
>> when the cpupool scheduler and the initial scheduler are
>> different.
>>
>> Correct this by destroying the domain's scheduling information
>> before removing it from the pool.
>>
>> Signed-off-by: Nathan Studer <nate.studer@dornerworks.com>
>
> Reviewed-by: Juergen Gross <juergen.gross@ts.fujitsu.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

>
>> ---
>>   xen/common/domain.c |    4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/xen/common/domain.c b/xen/common/domain.c
>> index 5999779..78ce968 100644
>> --- a/xen/common/domain.c
>> +++ b/xen/common/domain.c
>> @@ -727,10 +727,10 @@ static void complete_domain_destroy(struct
>> rcu_head *head)
>>
>>       rangeset_domain_destroy(d);
>>
>> -    cpupool_rm_domain(d);
>> -
>>       sched_destroy_domain(d);
>>
>> +    cpupool_rm_domain(d);
>> +
>>       /* Free page used by xen oprofile buffer. */
>>   #ifdef CONFIG_XENOPROF
>>       free_xenoprof_pages(d);
>>
>
>