From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juergen Gross Subject: Re: [Patch] Call sched_destroy_domain before cpupool_rm_domain. Date: Mon, 04 Nov 2013 10:58:20 +0100 Message-ID: <52776FBC.50800@ts.fujitsu.com> References: <1383534234-3933-1-git-send-email-nate.studer@dornerworks.com> <52773EF2.8000308@ts.fujitsu.com> <1383557167.9207.35.camel@Solace> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1383557167.9207.35.camel@Solace> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Dario Faggioli Cc: George Dunlap , Keir Fraser , Nathan Studer , Jan Beulich , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 04.11.2013 10:26, Dario Faggioli wrote: > On lun, 2013-11-04 at 07:30 +0100, Juergen Gross wrote: >> On 04.11.2013 04:03, Nathan Studer wrote: >>> From: Nathan Studer >>> >>> The domain destruction code, removes a domain from its cpupool >>> before attempting to destroy its scheduler information. Since >>> the scheduler framework uses the domain's cpupool information >>> to decide on which scheduler ops to use, this results in the >>> the wrong scheduler's destroy domain function being called >>> when the cpupool scheduler and the initial scheduler are >>> different. >>> >>> Correct this by destroying the domain's scheduling information >>> before removing it from the pool. >>> >>> Signed-off-by: Nathan Studer >> >> Reviewed-by: Juergen Gross >> > I think this is a candidate for backports too, isn't it? > > Nathan, what was happening without this patch? Are you able to quickly > figure out what previous Xen versions suffers from the same bug? In theory this bug is present since 4.1. OTOH it will be hit only with arinc653 scheduler in a cpupool other than Pool-0. And I don't see how this is being supported by arinc653 today (pick_cpu will always return 0). All other schedulers will just call xfree() for the domain specific data (and may be update some statistic data, which is not critical). Juergen -- Juergen Gross Principal Developer Operating Systems PBG PDG ES&S SWE OS6 Telephone: +49 (0) 89 62060 2932 Fujitsu e-mail: juergen.gross@ts.fujitsu.com Mies-van-der-Rohe-Str. 8 Internet: ts.fujitsu.com D-80807 Muenchen Company details: ts.fujitsu.com/imprint.html