Re: [PATCH v14 01/17] Allow vmx_update_debug_state to be called when v!=current

[George Dunlap <george.dunlap@eu.citrix.com>]

CC'ing the vmx maintainers...

On 04/11/13 12:14, George Dunlap wrote:
> Removing the assert allows the PVH code to call this during vmcs
> construction in a later patch, making the code more robust by removing
> duplicate code.
>
> Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com>
> ----
> v13: Add vmx_vmcs_{enter,exit}
>
> CC: Mukesh Rathor <mukesh.rathor@oracle.com>
> CC: Jan Beulich <jbeulich@suse.com>
> CC: Tim Deegan <tim@xen.org>
> CC: Keir Fraser <keir@xen.org>
> ---
>   xen/arch/x86/hvm/vmx/vmx.c |    5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
> index 9ca8632..fdb560e 100644
> --- a/xen/arch/x86/hvm/vmx/vmx.c
> +++ b/xen/arch/x86/hvm/vmx/vmx.c
> @@ -1051,8 +1051,6 @@ void vmx_update_debug_state(struct vcpu *v)
>   {
>       unsigned long mask;
>   
> -    ASSERT(v == current);
> -
>       mask = 1u << TRAP_int3;
>       if ( !cpu_has_monitor_trap_flag )
>           mask |= 1u << TRAP_debug;
> @@ -1061,7 +1059,10 @@ void vmx_update_debug_state(struct vcpu *v)
>           v->arch.hvm_vmx.exception_bitmap |= mask;
>       else
>           v->arch.hvm_vmx.exception_bitmap &= ~mask;
> +
> +    vmx_vmcs_enter(v);
>       vmx_update_exception_bitmap(v);
> +    vmx_vmcs_exit(v);
>   }
>   
>   static void vmx_update_guest_cr(struct vcpu *v, unsigned int cr)