Re: [PATCH 1/1] trace-cmd: use pkg-config instead of python-config

[Romain Naour <romain.naour@openwide.fr>]

Hi,

Le 04/11/2013 23:20, Darren Hart a écrit :
> I'm hardly an expert here, but the appears sane to me. Perhaps a
> comment above the PYTHON_VERS describing what valid values are would
> be helpful. Otherwise, looks good to me.

Expected values are "python" and "python3" for PYTHON_VERS.

trace-cmd has been added in buildroot right after the 2013.08 release,
but several build failures has occurred in autobuilder like this one:
http://autobuild.buildroot.net/results/980/980875810528ac1dee34b8c268d9b3c40b2e35ec/build-end.log

Currently, we have two separate package for python2 and python3 in buildroot,
that's why I use PYTHON_VERS here.

See how trace-cmd.mk use PYTHON_VERS:
http://git.buildroot.net/buildroot/commit/?id=ff0367008c683362f422751644237218b1c45def

Best regards,
Romain Naour

> 
> On Mon, Nov 4, 2013 at 12:32 AM, Johannes Berg
> <johannes@sipsolutions.net> wrote:
>> On Fri, 2013-11-01 at 17:19 -0400, Steven Rostedt wrote:
>>> Please Cc me on trace-cmd patches.
>>>
>>> Johannes and Darren,
>>>
>>> Since you handle the python bindings in trace-cmd, can you give me an
>>> ack or nack.
>>
>> Looks fine to me, in that it would work on my system :)
>>
>> johannes
>>
> 
> 
>