Re: [PATCH 2/7] common/vsprintf: Refactor pointer() out of vsnprintf()

[Andrew Cooper <andrew.cooper3@citrix.com>]

On 05/11/13 10:21, Jan Beulich wrote:
>>>> On 04.11.13 at 22:30, Andrew Cooper <andrew.cooper3@citrix.com> wrote:
>> No fuctional change
> functional
>
>> +    str = number(str, end, val, 16, field_width, precision, flags);
>> +
>> +    return str;
> Why not simply "return number(...);"?

I thought I did, although that appears to only have made it into the
subsequent patch.

>
>> @@ -399,13 +414,8 @@ int vsnprintf(char *buf, size_t size, const char *fmt, va_list args)
>>              continue;
>>  
>>          case 'p':
>> -            if (field_width == -1) {
>> -                field_width = 2*sizeof(void *);
>> -                flags |= ZEROPAD;
>> -            }
>> -            str = number(str, end,
>> -                         (unsigned long) va_arg(args, void *),
>> -                         16, field_width, precision, flags);
>> +            str = pointer(str, end, (unsigned long) va_arg(args, void *),
>> +                          field_width, precision, flags);
> The va_arg() result clearly shouldn't be cast here, even if both
> the use here and that added by the next patch require this. I'm
> definitely planning on adding a modifier to print domain/vcpu IDs
> as a pair from a single "struct vcpu *" argument, and such code
> shouldn't be required to cast back from "unsigned long" to a
> pointer.
>
> Jan

Ok - I will use a void* instead.

~Andrew

>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel