From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [RFC 7/8] x86/hpet: debug keyhandlers Date: Tue, 5 Nov 2013 11:16:00 +0000 Message-ID: <5278D370.7000908@citrix.com> References: <1383591286-19976-1-git-send-email-andrew.cooper3@citrix.com> <1383591286-19976-8-git-send-email-andrew.cooper3@citrix.com> <5278E05A02000078000FF7B2@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Vdec7-00023a-Dn for xen-devel@lists.xenproject.org; Tue, 05 Nov 2013 11:16:03 +0000 In-Reply-To: <5278E05A02000078000FF7B2@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: xen-devel List-Id: xen-devel@lists.xenproject.org On 05/11/13 11:11, Jan Beulich wrote: >>>> On 04.11.13 at 19:54, Andrew Cooper wrote: >> @@ -879,6 +896,8 @@ u64 __init hpet_setup(void) >> hpet_rate = 1000000000000000ULL; /* 10^15 */ >> (void)do_div(hpet_rate, hpet_period); >> >> + register_keyhandler('1', &hpet_dump_state); > I'd prefer the numbers to be left alone if at all possible. How > about 'E'? > > Jan > I wasn't intending for this keyhandler to be committed, at least certainly not taking the place of '1' (As people might be able to guess from similar debugging patches of mine, I regularly have many of the numbers in use for temporary keyhandlers) While it was very useful while working on this issue, I don't think it would be particularly useful in general, especially given the increasing scarcity of keys. ~Andrew