From: Eric Blake <eblake@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Andreas Faerber <afaerber@suse.de>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 6/7] qdev-monitor-test: add device_add leak test cases
Date: Tue, 05 Nov 2013 04:58:48 -0700 [thread overview]
Message-ID: <5278DD78.1000402@redhat.com> (raw)
In-Reply-To: <1383141276-19230-7-git-send-email-stefanha@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 708 bytes --]
On 10/30/2013 07:54 AM, Stefan Hajnoczi wrote:
> Ensure that the device_add error code path deletes device objects.
> Failure to do so not only leaks the objects but can also keep other
> objects (like drive or netdev) alive due to qdev properties holding
> references.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> tests/Makefile | 2 ++
> tests/qdev-monitor-test.c | 81 +++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 83 insertions(+)
> create mode 100644 tests/qdev-monitor-test.c
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-11-05 11:59 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-30 13:54 [Qemu-devel] [PATCH v3 0/7] qdev and blockdev refcount leak fixes Stefan Hajnoczi
2013-10-30 13:54 ` [Qemu-devel] [PATCH v3 1/7] blockdev: fix drive_init() opts and bs_opts leaks Stefan Hajnoczi
2013-11-05 11:48 ` Eric Blake
2013-10-30 13:54 ` [Qemu-devel] [PATCH v3 2/7] qdev: unref qdev when device_add fails Stefan Hajnoczi
2013-11-05 11:50 ` Eric Blake
2013-11-05 15:28 ` Stefan Hajnoczi
2013-10-30 13:54 ` [Qemu-devel] [PATCH v3 3/7] libqtest: rename qmp() to qmp_discard_response() Stefan Hajnoczi
2013-11-05 11:52 ` Eric Blake
2013-11-06 15:24 ` Andreas Färber
2013-10-30 13:54 ` [Qemu-devel] [PATCH v3 4/7] libqtest: add qmp(fmt, ...) -> QDict* function Stefan Hajnoczi
2013-11-05 11:56 ` Eric Blake
2013-11-06 15:32 ` Andreas Färber
2013-10-30 13:54 ` [Qemu-devel] [PATCH v3 5/7] blockdev-test: add test case for drive_add duplicate IDs Stefan Hajnoczi
2013-11-05 11:57 ` Eric Blake
2013-11-06 15:36 ` Andreas Färber
2013-10-30 13:54 ` [Qemu-devel] [PATCH v3 6/7] qdev-monitor-test: add device_add leak test cases Stefan Hajnoczi
2013-11-05 11:58 ` Eric Blake [this message]
2013-11-06 15:38 ` Andreas Färber
2013-10-30 13:54 ` [Qemu-devel] [PATCH v3 7/7] qdev: drop misleading qdev_free() function Stefan Hajnoczi
2013-11-05 12:06 ` Eric Blake
2013-10-30 15:44 ` [Qemu-devel] [PATCH v3 0/7] qdev and blockdev refcount leak fixes Andreas Färber
2013-10-31 9:22 ` Stefan Hajnoczi
2013-11-06 10:30 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5278DD78.1000402@redhat.com \
--to=eblake@redhat.com \
--cc=afaerber@suse.de \
--cc=armbru@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.