From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hannes Reinecke Subject: Re: [PATCH] dm-mpath: requeue I/O during pg_init Date: Tue, 05 Nov 2013 14:45:34 +0100 Message-ID: <5278F67E.2040402@suse.de> References: <1380620996-110162-1-git-send-email-hare@suse.de> <20131105130221.GC27505@agk-dp.fab.redhat.com> <5278EE5F.9070208@suse.de> <20131105133158.GD27505@agk-dp.fab.redhat.com> Reply-To: device-mapper development Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20131105133158.GD27505@agk-dp.fab.redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Alasdair Kergon , Junichi Nomura , Mike Snitzer , dm-devel@redhat.com List-Id: dm-devel.ids On 11/05/2013 02:31 PM, Alasdair G Kergon wrote: > On Tue, Nov 05, 2013 at 02:10:55PM +0100, Hannes Reinecke wrote: >> If this is just a left-over from the original port to request-based >> (for bio-based we _have_ to queue internally as there's no request >> queue to be had), fine, we should be removing it. > = > I think that is the case. > = >> But there _might_ be some corner cases which require us to do internal >> queueing. > = > We *only* add I/O to the internal queue in map_io() - which can always > be replaced with REQUEUE, As long as we still 'wake up' the queue > immediately when we are ready to receive the I/O, I can't think of any > other reason. And it would let us remove quite a bit of tricky code! > = Precisely what I was thinking. I'll be cobbling together a patch. Cheers, Hannes -- = Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg GF: J. Hawn, J. Guild, F. Imend=F6rffer, HRB 16746 (AG N=FCrnberg)