From mboxrd@z Thu Jan 1 00:00:00 1970 From: Don Slutz Subject: Re: [PATCH v3 3/3] get_maintainer.pl: Adjust to review comments Date: Tue, 5 Nov 2013 09:43:45 -0500 Message-ID: <52790421.7090502@terremark.com> References: <1383660711-12113-1-git-send-email-dslutz@terremark.com> <1383660711-12113-2-git-send-email-dslutz@terremark.com> <1383660711-12113-3-git-send-email-dslutz@terremark.com> <1383660711-12113-4-git-send-email-dslutz@terremark.com> <1383661151.13961.77.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8996685427219293205==" Return-path: In-Reply-To: <1383661151.13961.77.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Matthew Daley , Keir Fraser , Jan Beulich , Don Slutz , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org --===============8996685427219293205== Content-Type: multipart/alternative; boundary="------------070708080000090902030101" --------------070708080000090902030101 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit On 11/05/13 09:19, Ian Campbell wrote: > On Tue, 2013-11-05 at 09:11 -0500, Don Slutz wrote: >> From: Don Slutz > Please can you list the specific changes for the changelog. No need to > resend, I'll fold the list into the commit message. Not sure how much you want. Here is the long versions (Includeing the change fro reference): -my $email_git_fallback = 1; +my $email_git_fallback = 0; Date: Fri, 4 Oct 2013 19:03:44 +1300 From: Matthew Daley This script was discussed in the recent past ( http://lists.xen.org/archives/html/xen-devel/2013-03/msg00984.html ) and IIUC the consensus was that, if it were to go in, the Git fallback searches would be disabled ($email_git_fallback = 0, AFAIK). IMO It's not necessary for a (relative to Linux) small project like Xen, with adequate MAINTAINERS coverage, to need this fallback. -my $output_rolestats = 1; +my $output_rolestats = 0; Date: Fri, 4 Oct 2013 20:25:51 +1300 From: Matthew Daley Also, I think I needed to set $output_rolestats = 0 to get sensible output (without the unnecessary role stuff). +my $email_drop_the_rest_supporter_if_supporter_found = 1; + 'drop_the_rest_supporter!' => \$email_drop_the_rest_supporter_if_supporter_found, >> @@ -651,6 +653,19 @@ sub get_maintainers { >> } >> } >> >> + if ($email_drop_the_rest_supporter_if_supporter_found && $#email_to > 0) { >> + my @email_new; >> + my $do_replace = 0; >> + foreach my $email (@email_to) { >> + if ($email->[1] ne 'supporter:THE REST') { >> + $do_replace = 1; >> + push @email_new, $email; >> + } >> + } >> + @email_to = @email_new >> + if $do_replace; >> + } Date: Fri, 4 Oct 2013 19:03:44 +1300 From: Matthew Daley Also, speaking of adequate MAINTAINERS coverage, the last entry which attempts to have Keir as a fallback for "everything else" actually mean Keir is CC'd on everything using the script. This is because it uses all matching regexes and not just the most specific. Perhaps this entry needs to be commented out (leaving it their for manual inspection), or removed entirely? Date: Fri, 4 Oct 2013 10:35:19 +0100 From: Jan Beulich Or the script be made more intelligent? After all, the entry is there for a reason... > Just to confirm: This doesn't suppress any xen-devel@ CC, which should > always be there, does it? Nope. It only drops the e-mail (currently Keir Fraser) for "supporter:THE REST" role when any other role is found. Also you can turn it off with --nodrop_the_rest_supporter don-760:~/xen>scripts/get_maintainer.pl --nodrop_the_rest_supporter config_v2/0001-.config-Allow-all-URL-s-to-be-specified-in-.config.patch Keir Fraser Ian Jackson Stefano Stabellini Ian Campbell xen-devel@lists.xen.org don-760:~/xen>scripts/get_maintainer.pl config_v2/0001-.config-Allow-all-URL-s-to-be-specified-in-.config.patch Ian Jackson Stefano Stabellini Ian Campbell xen-devel@lists.xen.org -Don Slutz > Ian > --------------070708080000090902030101 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: 8bit
On 11/05/13 09:19, Ian Campbell wrote:
On Tue, 2013-11-05 at 09:11 -0500, Don Slutz wrote:

From: Don Slutz <dslutz@verizon.com>

Please can you list the specific changes for the changelog. No need to
resend, I'll fold the list into the commit message.
Not sure how much you want.

Here is the long versions (Includeing the change fro reference):

-my $email_git_fallback = 1;
+my $email_git_fallback = 0;

Date:     Fri, 4 Oct 2013 19:03:44 +1300
From:     Matthew Daley <mattjd@gmail.com>

This script was discussed in the recent past (
http://lists.xen.org/archives/html/xen-devel/2013-03/msg00984.html )
and IIUC the consensus was that, if it were to go in, the Git fallback
searches would be disabled ($email_git_fallback = 0, AFAIK). IMO It's
not necessary for a (relative to Linux) small project like Xen, with
adequate MAINTAINERS coverage, to need this fallback.

-my $output_rolestats = 1;
+my $output_rolestats = 0;

Date:     Fri, 4 Oct 2013 20:25:51 +1300
From:     Matthew Daley <mattjd@gmail.com>

Also, I think I needed to set $output_rolestats = 0 to get sensible
output (without the unnecessary role stuff).


+my $email_drop_the_rest_supporter_if_supporter_found = 1;
+               'drop_the_rest_supporter!' => \$email_drop_the_rest_supporter_if_supporter_found,

@@ -651,6 +653,19 @@ sub get_maintainers {
 	}
     }
 
+    if ($email_drop_the_rest_supporter_if_supporter_found && $#email_to > 0) {
+        my @email_new;
+        my $do_replace = 0;
+        foreach my $email (@email_to) {
+            if ($email->[1] ne 'supporter:THE REST') {
+                $do_replace = 1;
+                push @email_new, $email;
+            }
+        }
+        @email_to = @email_new
+            if $do_replace;
+    }


Date:     Fri, 4 Oct 2013 19:03:44 +1300
From:     Matthew Daley <mattjd@gmail.com>

Also, speaking of adequate MAINTAINERS coverage, the last entry which
attempts to have Keir as a fallback for "everything else" actually
mean Keir is CC'd on everything using the script. This is because it
uses all matching regexes and not just the most specific. Perhaps this
entry needs to be commented out (leaving it their for manual
inspection), or removed entirely?

Date:     Fri, 4 Oct 2013 10:35:19 +0100
From:     Jan Beulich <JBeulich@suse.com>

Or the script be made more intelligent? After all, the entry is there
for a reason...

Just to confirm: This doesn't suppress any xen-devel@ CC, which should
always be there, does it?
Nope.  It only drops the e-mail (currently Keir Fraser) for "supporter:THE REST" role when any other role is found. Also you can turn it off with --nodrop_the_rest_supporter

don-760:~/xen>scripts/get_maintainer.pl --nodrop_the_rest_supporter config_v2/0001-.config-Allow-all-URL-s-to-be-specified-in-.config.patch
Keir Fraser <keir@xen.org>
Ian Jackson <ian.jackson@eu.citrix.com>
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Ian Campbell <ian.campbell@citrix.com>
xen-devel@lists.xen.org

don-760:~/xen>scripts/get_maintainer.pl config_v2/0001-.config-Allow-all-URL-s-to-be-specified-in-.config.patch
Ian Jackson <ian.jackson@eu.citrix.com>
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Ian Campbell <ian.campbell@citrix.com>
xen-devel@lists.xen.org

   -Don Slutz

Ian

--------------070708080000090902030101-- --===============8996685427219293205== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============8996685427219293205==--