All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <rth@twiddle.net>
Cc: Dinar Valeev <dvaleev@suse.de>, Dinar Valeev <dvaleev@suse.com>,
	Dinar Valeev <k0da@opensuse.org>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] configure: Enable pie for powerpc and arm Linux
Date: Tue, 05 Nov 2013 18:50:37 +0100	[thread overview]
Message-ID: <52792FED.1060305@suse.de> (raw)
In-Reply-To: <52780EA4.5050702@redhat.com>

Am 04.11.2013 22:16, schrieb Paolo Bonzini:
> Il 04/11/2013 21:51, Richard Henderson ha scritto:
>>>>  if test "$pie" = ""; then
>>>>    case "$cpu-$targetos" in
>>>> -    i386-Linux|x86_64-Linux|x32-Linux|i386-OpenBSD|x86_64-OpenBSD)
>>>> +    i386-Linux|x86_64-Linux|x32-Linux|ppc*-Linux|arm*-Linux|aarch64*-Linux|i386-OpenBSD|x86_64-OpenBSD)
>> I'd much prefer that we have a blacklist than a whitelist for this.
>> Honestly, most ELF systems can support PIE, and we have very few
>> non-ELF systems to support.
> 
> Since the test is followed by a compile test, we probably do not even
> need the whitelist.

I remember reading a report here that someone ran into a link issue with
PIE on x86 at build time (check went okay) and was able to resolve it
via --disable-pie. Unfortunately I couldn't locate the post - do you
remember what that was about? Was that some BSD rather than Linux maybe?

It's probably a good idea to still allow overriding it, whether we
white- or blacklist or trust a compile test.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

  reply	other threads:[~2013-11-05 17:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-04 12:19 [Qemu-devel] [PATCH] configure: Enable pie for powerpc and arm Linux Dinar Valeev
2013-11-04 20:51 ` Richard Henderson
2013-11-04 21:16   ` Paolo Bonzini
2013-11-05 17:50     ` Andreas Färber [this message]
2013-11-05 17:46 ` Andreas Färber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52792FED.1060305@suse.de \
    --to=afaerber@suse.de \
    --cc=dvaleev@suse.com \
    --cc=dvaleev@suse.de \
    --cc=k0da@opensuse.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.