Re: [PATCH v3 2/8] iio: hid-sensors: accelerometer: Add sensitivity

[Jonathan Cameron <jic23@kernel.org>]

On 10/30/13 22:48, Srinivas Pandruvada wrote:
> A number of Properties that can be applied to Data Fields are per data
> field basis or for all data fields. Adding sensitivity field for all
> accelerometer fields, which is most commonly used in currently
> available sensor hubs.
> 
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
The defines needed for this bled into patch 6.  Please build test you individual
patches to makes sure they can be bisected.

Anyhow fixed that up and applied to the togreg branch of iio.git

> ---
>  drivers/iio/accel/hid-sensor-accel-3d.c | 12 ++++++++++++
>  include/linux/hid-sensor-ids.h          |  1 +
>  2 files changed, 13 insertions(+)
> 
> diff --git a/drivers/iio/accel/hid-sensor-accel-3d.c b/drivers/iio/accel/hid-sensor-accel-3d.c
> index 7fbe136..b89ba92 100644
> --- a/drivers/iio/accel/hid-sensor-accel-3d.c
> +++ b/drivers/iio/accel/hid-sensor-accel-3d.c
> @@ -261,6 +261,18 @@ static int accel_3d_parse_report(struct platform_device *pdev,
>  			st->accel[1].index, st->accel[1].report_id,
>  			st->accel[2].index, st->accel[2].report_id);
>  
> +	/* Set Sensitivity field ids, when there is no individual modifier */
> +	if (st->common_attributes.sensitivity.index < 0) {
> +		sensor_hub_input_get_attribute_info(hsdev,
> +			HID_FEATURE_REPORT, usage_id,
> +			HID_USAGE_SENSOR_DATA_MOD_CHANGE_SENSITIVITY_ABS |
> +			HID_USAGE_SENSOR_DATA_ACCELERATION,
> +			&st->common_attributes.sensitivity);
> +		dev_dbg(&pdev->dev, "Sensitivity index:report %d:%d\n",
> +			st->common_attributes.sensitivity.index,
> +			st->common_attributes.sensitivity.report_id);
> +	}
> +
>  	return ret;
>  }
>  
> diff --git a/include/linux/hid-sensor-ids.h b/include/linux/hid-sensor-ids.h
> index 8323775..bd97d60 100644
> --- a/include/linux/hid-sensor-ids.h
> +++ b/include/linux/hid-sensor-ids.h
> @@ -23,6 +23,7 @@
>  
>  /* Accel 3D (200073) */
>  #define HID_USAGE_SENSOR_ACCEL_3D				0x200073
> +#define HID_USAGE_SENSOR_DATA_ACCELERATION			0x200452
>  #define HID_USAGE_SENSOR_ACCEL_X_AXIS				0x200453
>  #define HID_USAGE_SENSOR_ACCEL_Y_AXIS				0x200454
>  #define HID_USAGE_SENSOR_ACCEL_Z_AXIS				0x200455
>